Skip to content

edm4hep: patch for new podio arrow targets - #6268

Open
wdconinc wants to merge 1 commit into
developfrom
edm4hep-podio-arrow
Open

edm4hep: patch for new podio arrow targets#6268
wdconinc wants to merge 1 commit into
developfrom
edm4hep-podio-arrow

Conversation

@wdconinc

Copy link
Copy Markdown
Contributor

This PR updates edm4hep to use the new podio +arrow targets, which ended up landing with a different name than what made it into the 1.1 release. See key4hep/EDM4hep#509.

@wdconinc
wdconinc requested review from tmadlener and a lite review from Copilot August 28, 2026 19:58
@spackbot-triage spackbot-triage Bot added patch Modifications to packages' sets of defined patches update-package Modifications to packages in the repository labels Aug 28, 2026
@spackbot-triage
spackbot-triage Bot requested review from jmcarcell and vvolkl August 28, 2026 19:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Spack recipe for edm4hep to apply an upstream backport patch for the 1.1 release so it can build against the updated podio Arrow-related CMake targets/library naming (per key4hep/EDM4hep#509).

Changes:

  • Add an upstream commit patch to edm4hep@1.1 that updates its CMake configuration for the new PodioArrow naming/suffix.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@jmcarcell jmcarcell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessary to configure with the latest tag of podio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Modifications to packages' sets of defined patches update-package Modifications to packages in the repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants