sepp: fix build with Python 3.12+ (distutils removal) - #6272
Open
gonzabotmdp wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sepp'ssetup.pyfails under Python 3.12+ with:Two separate issues in
setup.py, both from the same root cause (distutilsremoved from the stdlib in 3.12+):from distribute_setup import use_setuptools+use_setuptools(version="0.6.24")-- a 2010-era helper script (from back whensetuptools/distributewere separate forks, merged back together in 2013) that bootstraps installing setuptools if it's missing. Completely obsolete: setuptools has shipped by default for well over a decade, and this package already unconditionally doesfrom setuptools import find_packagestwo lines below. Dropped entirely.from distutils.core import setup, Command--setuptools.Commandis a documented drop-in fordistutils.core.Command(theConfigSeppsubclass's own docstring literally says "setuptools Command"), andsetuptools.setupfordistutils.core.setup. Switched the import.Testing
Installed
sepp@4.5.1(abusco@6.1.0dependency) end to end with Python 3.14, confirmed the install phase completes and produces working binaries.