py-quast: drop vestigial boost pin, fix Python 3.12+ compat, fix bundled minimap2 permissions - #6273
Open
gonzabotmdp wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three independent, real issues found installing/using
py-quast@5.2.0for a genome-assembly QC pipeline:1. Vestigial
depends_on("boost@1.56.0").setup.pynever references boost at all (confirmed by grepping the full sdist) -- the pin is most likely inherited by copy-paste from the vendored BamTools/bedtools copies bundled insidequast_libs/for offline use, but those vendored copies aren't what actually gets built; Spack's own separatebedtools2/glimmer/bwadependencies (already declared below) are. The pin drags in an ancient (2014) boost version purely for no reason. Dropped it (plus the now-unusedBoost.with_default_variantsimport).2.
distutilsremoval (Python 3.12+).quast_libs/qconfig.pydoesfrom distutils.version import LooseVersionjust to check the running Python version falls within quast's own supported range.packaging.version.Versionis a drop-in for the comparison usage here (Version(str),<,<=). Addeddepends_on("py-packaging")and swapped the import.3. Bundled minimap2 fails for any user but the one who ran
spack install.quast_libs/minimap2is quast's own vendored minimap2 source, compiled lazily on first use viaqutils.compile_tool()-- by design for a normal per-user pip install, but under Spack the install tree is only writable by whoever ran the install. Any other user runningquast.py -r(reference alignment, the single most common invocation) hits aPermissionErrortrying to writequast_libs/minimap2/minimap2. Added a@run_after("install")hook that compiles it once duringspack installitself (while install-tree write access is still available), so the binary is already built and world-readable/executable before any user touches it.Testing
Installed
py-quast@5.2.0, confirmedquast.py --versionworks, confirmed the bundledminimap2binary is present withrwxr-xr-xpermissions immediately after install (no lazy-compile step needed), and confirmed a realquast.py -r <reference>run (previously failing withPermissionErrorfor a second, non-owner user) completes.