Skip to content

Fix CMake error with set_source_files_properties COMPILE_FLAGS in ck #6275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmelone merged 2 commits into from
Sep 1, 2026
Merged

Fix CMake error with set_source_files_properties COMPILE_FLAGS in ck #6275

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b18eed4
Fix CMake error with set_source_files_properties COMPILE_FLAGS in ck
renjithravindrankannath Aug 28, 2026
7f9c0d8
replacing PR with commit reference
renjithravindrankannath Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions repos/spack_repo/builtin/packages/composable_kernel/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,15 @@ def url_for_version(self, version):
# https://github.com/ROCm/composable_kernel/commit/959073842c0db839d45d565eb260fd018c996ce4
patch("0001-mark-kernels-maybe-unused.patch", when="@6.2")

# Fix CMake error with set_source_files_properties COMPILE_FLAGS
# The offload_targets variable contains spaces and needs to be quoted
# PR: https://github.com/ROCm/rocm-libraries/pull/11440
patch(
"https://github.com/ROCm/rocm-libraries/commit/17f401ff6fdb33828c505a70c7dad126ad437150.patch?full_index=1",
when="@7.14.0",
sha256="bd5b65d48b23a8fa489a302c32d6d2029a4ea76ece4b48ee9cb6b7b7840efa5c",
)

@property
def root_cmakelists_dir(self):
if self.spec.satisfies("@7.2:"):
Expand Down
Loading