boost: add v1.92.0, v1.91.0 - #6284
Open
wdconinc wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the built-in Spack boost package to add upstream Boost releases 1.91.0 and 1.92.0, and adjusts the Boost.Build python.jam patching to better handle Python include directory ABI suffixes for newer Boost versions.
Changes:
- Added Boost versions
1.91.0and1.92.0(new source checksums). - Introduced a new
python_jam-1_91.patchand adjusted patch applicability ranges so Boost@1.91:uses the updated patch.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| repos/spack_repo/builtin/packages/boost/python_jam-1_91.patch | Adds sys.abiflags probing and uses it in default Python include path computation for Boost.Build, with updated suffix handling for newer Boost versions. |
| repos/spack_repo/builtin/packages/boost/package.py | Adds Boost 1.91.0/1.92.0 versions and updates which python_jam patch applies for @1.91: vs @1.77:1.90. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
boost, v1.91.0 (release notes) and v1.92.0 (release notes).Notes for 1.91.0:
This will fix a bunch of packages that have
find_package(Boost REQUIRED system).(There was a 1.91.0-1 release tag without artifacts, and it only differs in a CI yml file.)
Notes for 1.92.0:
find_packagecomponents"This should now allow
find_package(Boost REQUIRED system)to work for all header-only components (or library components that become header-only).Relevant upstream commit for the changed patch (it is literally just a change from 'm' to 't' in the patch): boostorg/build@125be3e. Technically, this may make the patch unnecessary in some cases, but the patch introduces a more robust approach (e.g. it handles all ABI flags, including 'd', which the upstream commit will still fail to catch).
Test build: