feat(terminal): follow browser navigation in the embedded terminal - #1
Closed
spandan11106 wants to merge 1 commit into
Closed
spandan11106 wants to merge 1 commit into
spandan11106 wants to merge 1 commit into
Conversation
The embedded terminal now tracks the folder the browser is showing. The browser stays the source of truth: navigation is observed, never driven. A directory change is only injected when the shell itself owns the terminal and the user has left no half-typed line at the prompt. tcgetpgrp reports the first; the commit signal tracks the second, which tcgetpgrp cannot see. While neither holds, the newest requested folder is held and retried until the shell is free, so navigating past several folders while a build or an editor runs applies only the last of them. Locations with no local path, trash included, pause synchronisation rather than inventing a path. The panel now follows the location in the breadcrumb rather than the hovered column, so it matches what the window says it is showing. Ctrl+T is unchanged and still acts on a selected folder. Refs lgse#93
Owner
Author
|
Reopened against lgse/strata as lgse#1093, now that the base branch exists there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacked on
feat/93-embedded-terminal(lgse#1089). Only the second commit belongs to this change; review the diff against that base.Second of the three steps on lgse#93: the embedded terminal now follows the folder the browser is showing.
tcgetpgrpon the PTY reports the first. The second is invisible totcgetpgrp, so VTE'scommitsignal tracks whether the current line was submitted or discarded.Ctrl+Tis unchanged and still acts on a selected folder.Still one-way: nothing reads the shell's own
cdback into the browser.Visual evidence
Pending — a short video showing navigation following, a busy shell being left alone, and the deferred change landing afterwards will follow in a comment.
How to test
F4, runpwd.pwdin the panel again — it followed.sleep 15; echo DONEand navigate to a different folder while it runs. Nothing is injected; the sleep is untouched.echo HALF-TYPEDwithout pressing Enter, then navigate elsewhere. The typed line is still intact and unchanged.Expected result: the terminal tracks the browser while the shell is idle, never interrupts a running process or corrupts typed input, applies only the newest pending folder once it can, and leaves non-local locations alone.
Related issue
Refs lgse#93