Skip to content

fix: display all gems in gem list by using dynamic statusbar height - #33

Merged
spaquet merged 6 commits into
mainfrom
fix/ui
Apr 6, 2026
Merged

fix: display all gems in gem list by using dynamic statusbar height#33
spaquet merged 6 commits into
mainfrom
fix/ui

Conversation

@spaquet

@spaquet spaquet commented Apr 6, 2026

Copy link
Copy Markdown
Owner

The gems list was truncating the last 2 gems (#61-#62) because:

  1. Offset calculation used hardcoded FixedChrome=3 assuming statusbar=1 line
  2. But statusbar can grow to 2-3 lines during health/update checks
  3. This mismatch caused gems to be unreachable by scrolling
  4. Overflow trimming was too aggressive, cutting gem rows

Fix:

  • Use dynamic statusBarTotalHeight() in offset/cursor calculations
  • Improve overflow trimming to only trim >1 line excess
  • Keep 1 extra line to preserve access to last gems

Now all 62 first-level gems are accessible and displayable.

Fixes #32

The gems list was truncating the last 2 gems (#61-#62) because:
1. Offset calculation used hardcoded FixedChrome=3 assuming statusbar=1 line
2. But statusbar can grow to 2-3 lines during health/update checks
3. This mismatch caused gems to be unreachable by scrolling
4. Overflow trimming was too aggressive, cutting gem rows

Fix:
- Use dynamic statusBarTotalHeight() in offset/cursor calculations
- Improve overflow trimming to only trim >1 line excess
- Keep 1 extra line to preserve access to last gems

Now all 62 first-level gems are accessible and displayable.

Fixes #32

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@spaquet spaquet self-assigned this Apr 6, 2026
@spaquet spaquet added the bug Something isn't working label Apr 6, 2026
spaquet and others added 5 commits April 5, 2026 18:12
The TestAnalyze_ListopiaGemfile test uses a hardcoded path that only
exists on the developer's machine. Skip the test gracefully in CI/other
environments instead of failing.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Configure CodeQL with CODEQL_ACTION_FILE_COVERAGE_ON_PRS=true to keep
computing file coverage information on pull requests, avoiding the
deprecation warning from GitHub.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Default CodeQL setup is already enabled on GitHub. Remove custom
workflow to avoid conflict. The deprecation warning about file coverage
on PRs can be addressed in GitHub repository settings if needed.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Configure CodeQL with FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true to
upgrade from deprecated Node.js 20 to Node.js 24 actions.

Also enable CODEQL_ACTION_FILE_COVERAGE_ON_PRS to maintain file
coverage information on pull requests.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Default CodeQL setup is already enabled on GitHub, which conflicts with
custom advanced setup. The default setup will be automatically updated
by GitHub to use Node.js 24.

To control CodeQL configuration (including file coverage), disable the
default setup in GitHub repository settings and re-enable this workflow.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@spaquet
spaquet merged commit da8ec30 into main Apr 6, 2026
5 checks passed
@spaquet
spaquet deleted the fix/ui branch April 6, 2026 01:25
@spaquet
spaquet restored the fix/ui branch April 6, 2026 05:34
@spaquet
spaquet deleted the fix/ui branch April 6, 2026 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gems list truncated: last 2 rows missing from table

1 participant