[sub-PR] Constrain useFirestoreConnect query types to enforce our firestore query patterns#1076
Merged
mike-lvov merged 1 commit intoJan 14, 2021
Conversation
…ery patterns + update related usages
Contributor
Author
0xdevalias
commented
Jan 14, 2021
Comment on lines
7
to
+9
| const WelcomePage: React.FunctionComponent = () => { | ||
| // @dept Probably we should remove this piece of software if it is not functional anymore | ||
| useFirestoreConnect("marketingemails" as ValidFirestoreKeys); | ||
| // @debt we should remove this code file if it's not being used anymore | ||
| useFirestoreConnect("marketingemails" as ValidFirestoreRootCollections); |
Contributor
Author
There was a problem hiding this comment.
[OOS] We should remove this code file if it's not being used anymore
mike-lvov
approved these changes
Jan 14, 2021
mike-lvov
added a commit
that referenced
this pull request
Jan 14, 2021
…FirestoreConnect import (#801) * Undo "Revert "Prevent pathological queries when doc is not specified (#784)" (#797)" * Replace useParam usage with useVenueId across the codebase * constrain useFirestoreConnect query types to enforce our firestore query patterns + update related usages (#1076) Co-authored-by: Chris Adams <chris@cadams.com.au> Co-authored-by: Mike Lvov <mike.lvov.soft@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Sub-PR to #801 that constrains the
useFirestoreConnectquery types to enforce our firestore query patterns.This reinstates and improves upon the original type narrowing intended by #784, as called out in #801 (comment)