Revert "Prevent pathological queries when doc is not specified"#797
Conversation
This reverts commit 046fd47. This is an emergency fix to restore admin functionality.
|
@0xdevalias PTAL |
0xdevalias
left a comment
0xdevalias
left a comment
There was a problem hiding this comment.
Approved (retroactively).
Musing: I think for 'emergency fixes' we need a workflow where we can easily get them through to prod, even if there isn't necessarily someone around who can approve it.
My desire is that everything at least has a PR for visibility/documenting it/etc, but I don't necessarily think that needs to be reviewed/approved.
Have some thoughts i'll let brew on this and we can figure a good pattern/solution moving forward.
0xdevalias
added
the
❌ do-not-merge
|
This highlights another issue with the way our current workflows are configured, at least for this use case. It's wanting us to make a squash merge for this.. but I think for a revert that may not be something we actually want to do.. not sure, what do you think? @thecadams |
Yep we need ability to break glass. Asked here: https://stackoverflow.com/questions/64998944/ability-to-break-glass-and-bypass-github-branch-protection-for-emergency-fixes |
|
That StackOverflow is great! Opened a draft PR at sparkletown/.github#1 where we can make this happen! 🎉 Edit: Also backlogged https://github.com/sparkletown/internal-sparkle-issues/issues/13 to implement some automated/bot-based stuff around our current manual break-glass methods. |
0xdevalias
changed the title
0xdevalias
removed
the
❌ do-not-merge
0xdevalias
added
the
🔨🍷 break-glass-approval-bypass
…FirestoreConnect import (#801) * Undo "Revert "Prevent pathological queries when doc is not specified (#784)" (#797)" * Replace useParam usage with useVenueId across the codebase * constrain useFirestoreConnect query types to enforce our firestore query patterns + update related usages (#1076) Co-authored-by: Chris Adams <chris@cadams.com.au> Co-authored-by: Mike Lvov <mike.lvov.soft@gmail.com>
2 participants
This reverts commit 046fd47: "Prevent pathological queries when doc is not specified (#784)"
This is an emergency fix to restore admin functionality.