Open
Conversation
rr326
added a commit
to rr326/simplemde-markdown-editor
that referenced
this pull request
Apr 18, 2019
sparksuite#741 >> gulp works.
Someguy123
added a commit
to Privex/simplemde-markdown-editor
that referenced
this pull request
Oct 20, 2020
This commit includes the fixes introduced in Pull Request sparksuite#741 ( sparksuite#741 ) that were added by @roipoussiere It also includes these extra improvements: - Added lines for `no-redeclare` and `no-prototype-builtins` to `.estlintrc` which are set to disable warnings and errors for (re-)declaring global variables/functions like `require`, and disabling errors/warnings for prototyping built-ins e.g. extending `Object` - This was required for `gulp browserify` to build the scripts without errors - Added `yarn.lock` to lock package versions for those of you who use `yarn` instead of `npm` :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we get an error when typing the
gulpcommand, because the gulpfile is outdated.This PR updates the gulpfile to be compatible with gulp4.
Also, it disables
no-useless-escapeeslint rule, which is too aggressive and returns a lot of errors in current base-code.