fix(build): resolve MSIX source icon under assets/branding - #92
Merged
Conversation
….5 move - create_msix_placeholder_pngs.py looked for assets/pdfreader_by_sparsh.ico and assets/icon-150x150.png, which the v1.2.5 branding restructure moved to assets/branding/. The release workflow's MSIX build failed with "No source icon found". Now searches both assets/ and assets/branding/, preferring the .ico and falling back to the PNG. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v1.2.5 branding restructure moved the MSIX source icon from
assets/toassets/branding/, buttools/create_msix_placeholder_pngs.pystill looked for the old top-level paths — so the v1.2.7 release workflow's MSIX step failed with "No source icon found".This fixes the source-icon resolution to search both
assets/andassets/branding/(preferring the .ico, falling back to the PNG). Verified locally: all five MSIX PNGs generate correctly. Needed for the v1.2.7 retagged release.Co-Authored-By: Claude noreply@anthropic.com