Fix support for node 11.1 and above#13
Conversation
|
Yay! can we get a release? |
|
Yeap. Looking forward to release |
not on the last version 4.0.1 |
|
We need this fix asp, please. We are struggling with this error for months. |
|
When will this be released? |
|
Is there any date scheduled to release this fix? |
|
Please merge! |
|
I just want to echo what aaclayton said. Please, please merge this fix. |
|
@daviddias @jacobheun What about this PR for adding http2 support to node 12 LTS ?? |
|
Since this doesn't seem to be getting merged anytime soon, I thought I'd share my patch |
|
Published as 2.0.1 |
Many Thanks, @indutny! |
|
It still fails on node 12 in mid-Sept 2020. |
|
Works for me in node 14. Update to the last version and it should be working fine |
|
@adityashukla74 Make sure you've cleared node_modules and reinstalled, double check your package lock and ensure that handle-thing is >= 2.0.1 and it should work, however ensure you test it locally (by spamming refresh or something to create/kill some reqs before they can complete) before going to prod with newer versions of v12 due to this (unrelated) issue: Hopefully this patch to |
|
@aphix I tried with Node v12.13.0 LTS. webpack: Compiled successfully. RangeError: Invalid typed array length: -4095 npm ERR! A complete log of this run can be found in: |
|
That's a different issue @adityashukla74 -- also I've looked further and that solution isn't viable in either case. That sounds like this package using something not available to your webpack build and far outside the scope of this package. I think you might be using a wrong tool for a job somewhere, good luck. |
|
that does look like the old error though... what are the outputs of |
…on Node 16+
Two follow-ups to the earlier deceiver fix; both surfaced when bringing
up gcp2-dev03-00 on Node 24.
1. handle-thing@^1.2.5 calls socket._handle.onread with the old
(nread, buffer) signature. On Node 11.1+, the handle's onread is
actually node:internal/stream_base_commons.onStreamRead(arrayBuffer),
which reads nread from streamBaseState[kReadBytesOrError]. Passing
UV_EOF (-4095) as the arrayBuffer arg made onStreamRead try
`new FastBuffer(-4095, ...)` and crash:
RangeError: Invalid typed array length: -4095
at new FastBuffer (node:internal/buffer:956:1)
at Handle.onStreamRead [as onread]
(node:internal/stream_base_commons:188:19)
at Stream.<anonymous> (.../handle-thing/lib/handle.js:120:12)
handle-thing@2.0.1 (spdy-http2/handle-thing#13) translates the
call: it sets streamBaseState[kReadBytesOrError] first and then
invokes onread with just the buffer. It also adds .writev which
modern net.Socket needs. Bump the dependency.
2. The previous deceiver fallback used `require('http').METHODS` for
the methods list. http.METHODS is alphabetically sorted, but the
parser's internal index is the llhttp/http_parser order
(DELETE, GET, HEAD, POST, ...). Sending the alphabetical index made
Node interpret POST as ACL etc. Use `_http_common.methods`
(or `node:_http_common.methods`), which is the real parser-indexed
list.
Smoke-tested end-to-end on Node v24.11.1: spdy.createServer with TLS
+ h2 alpn, hit with the built-in http2 client, POST /, 11-byte body,
server sees method=POST, body bytes flow through handle-thing's data
path, EOF path completes without the -4095 crash, client receives
200 OK with the response body.
Co-authored-by: Cursor <cursoragent@cursor.com>
20 participants
Fixes #6
Took a stab at trying to fix
onreadsupport for node 11.1 and above.Looked at https://github.com/nodejs/node/blob/v11.1.0/lib/internal/stream_base_commons.js#L111 to figure out how to pass
nreadConfirmed on master https://github.com/nodejs/node/blob/master/lib/internal/stream_base_commons.js#L163 that the implement hasn't changed since then
This change is