Skip to content

[PMM-275] OAS Hub: Security#39

Merged
chailandau merged 11 commits into
speakeasy-api:mainfrom
philsturgeon:oas/security
Jun 4, 2025
Merged

[PMM-275] OAS Hub: Security#39
chailandau merged 11 commits into
speakeasy-api:mainfrom
philsturgeon:oas/security

Conversation

@philsturgeon
Copy link
Copy Markdown
Contributor

@philsturgeon philsturgeon commented May 23, 2025

Takes care of PMM-278, PMM-279, РMM-280, PMM-281, and PMM-282, so lets see how good the Linear integration is.

A refresh of the security / security requirements content. Needs a little more work but its trying to be a bit more human and explain things beyond just the objects.

Also:

  • Merges HTTP Basic, Digest and Bearer under one "HTTP Auth" page because its the same thing.
  • Removed openapi/security-schemes/index.mdx which seems to be identical to openapi/security/security-schemes.md (let me know if this was the wrong way around)

@philsturgeon philsturgeon requested a review from a team as a code owner May 23, 2025 17:53
@philsturgeon philsturgeon marked this pull request as draft May 23, 2025 17:54
@philsturgeon philsturgeon changed the title [PMM-275] OAS Hub: security [PMM-275] OAS Hub: Security May 23, 2025
Comment thread openapi/security/security-schemes.md Outdated
Comment thread openapi/security/security-schemes.md Outdated
Comment thread openapi/security/security-schemes.md Outdated
Comment thread openapi/security/security-schemes.md Outdated
Comment thread openapi/security/security-schemes.md Outdated
Comment thread openapi/security/security-schemes.md Outdated
Comment thread openapi/security/security-schemes.md Outdated
Comment thread openapi/security/security-schemes.md Outdated
Comment thread openapi/security/security-schemes.md Outdated
Comment thread openapi/security/security-schemes.md Outdated
Comment thread openapi/security/security-schemes.md Outdated

## How to describe security schemes

[securitySchemes](https://spec.openapis.org/oas/v3.1.0#security-scheme-object/security-schemes) are the actual details of the options provided in the [security](https://spec.openapis.org/oas/v3.1.0#security-requirement-object) sections of your document. The security schemes are components that are defined with the [components](https://spec.openapis.org/oas/v3.1.0#components-object) section of your document. Below is an example of the 5 types of security schemes described above and how they are defined:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid start!

I'd say the thing to decide on is capitalization for security schemes and then be consistent :)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chailandau I remember the style guide suggesting new concepts should be capitalized then it could be referred to as normal lowercase from there. I think it would look a little odd if it was always upper?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamsimonyu thoughts here? I can't seem to find that bit of the style guide and will defer to you

Comment thread openapi/security/security-schemes/security-http.mdx Outdated
Comment thread openapi/security/security-schemes/security-http.mdx Outdated
Comment thread openapi/security/security-schemes/security-http.mdx Outdated
Comment thread openapi/security/security-schemes/security-http.mdx Outdated
Comment thread openapi/security/security-schemes/security-http.mdx Outdated
philsturgeon and others added 10 commits June 3, 2025 16:57
seems to be some duplication on index.mdx so removed for now. need to properly seperate and cross link security schemes vs requirements.
Co-authored-by: Chai Landau <112015853+chailandau@users.noreply.github.com>
Co-authored-by: Chai Landau <112015853+chailandau@users.noreply.github.com>
@philsturgeon philsturgeon marked this pull request as ready for review June 3, 2025 16:32
@philsturgeon
Copy link
Copy Markdown
Contributor Author

@chailandau alright! This is ready for review now (conten complete) and I'm here for any sort of feedback you have.

@chailandau chailandau requested a review from iamsimonyu June 3, 2025 20:14
@chailandau chailandau merged commit 36b498c into speakeasy-api:main Jun 4, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants