The dumper's side-file outputs are dead weight, and Clava still carries their names in a cleanup list.
CLANG_AST_DUMPER_TEMP_FILES in ClangAstParser/src/pt/up/fe/specs/clang/dumper/ClangAstDumper.java:65-69 lists, among others: is_temporary.txt, omp.txt, enum_integer_type.txt, consumer_order.txt and types_with_templates.txt.
Findings from auditing clang-dumper (specs-feup/clang-dumper#30 removes the writer side):
- Nothing in Clava ever reads these files. The list is only used for cleanup —
CxxWeaver.java:802 deletes each entry when CLEAN_INTERMEDIATE_FILES is set.
- The Java-side readers were removed back in Aug 2021 (
6a004a58b: old ClangAstParser.java read is_temporary.txt / enum_integer_type.txt; consumer_order.txt was only a debug check disabled in 2018). omp.txt's parser was never wired up at all (commented out since the 2017 repo split), and types_with_templates.txt was never written nor read by any commit in history.
- The same data reaches Clava through the stderr line stream instead (
ExprDataParser for temporary-object flags, DeclDataParser for enum integer types).
Suggested change: drop is_temporary.txt, omp.txt, enum_integer_type.txt, consumer_order.txt, types_with_templates.txt (and the already-stale commented-out entries like template_args.txt) from the list once specs-feup/clang-dumper#30 lands. Optionally keep the list for files the dumper still produces (includes.txt, clangDump.txt, clavaDump.txt, nodetypes.txt, types.txt, invalid_source.txt).
The dumper's side-file outputs are dead weight, and Clava still carries their names in a cleanup list.
CLANG_AST_DUMPER_TEMP_FILESinClangAstParser/src/pt/up/fe/specs/clang/dumper/ClangAstDumper.java:65-69lists, among others:is_temporary.txt,omp.txt,enum_integer_type.txt,consumer_order.txtandtypes_with_templates.txt.Findings from auditing clang-dumper (specs-feup/clang-dumper#30 removes the writer side):
CxxWeaver.java:802deletes each entry whenCLEAN_INTERMEDIATE_FILESis set.6a004a58b: oldClangAstParser.javareadis_temporary.txt/enum_integer_type.txt;consumer_order.txtwas only a debug check disabled in 2018).omp.txt's parser was never wired up at all (commented out since the 2017 repo split), andtypes_with_templates.txtwas never written nor read by any commit in history.ExprDataParserfor temporary-object flags,DeclDataParserfor enum integer types).Suggested change: drop
is_temporary.txt,omp.txt,enum_integer_type.txt,consumer_order.txt,types_with_templates.txt(and the already-stale commented-out entries liketemplate_args.txt) from the list once specs-feup/clang-dumper#30 lands. Optionally keep the list for files the dumper still produces (includes.txt,clangDump.txt,clavaDump.txt,nodetypes.txt,types.txt,invalid_source.txt).