Multi-weaver - #52
Open
lm-sousa wants to merge 5 commits into
Open
Conversation
- Updated FunctionalClassGenerator to accept JavaWeaver as a parameter for method generation. - Modified ActionUtils to pass JavaWeaver instance during code insertion and expression replacement. - Enhanced SelectUtils to utilize JavaWeaver in join point conversions for statements and expressions. - Refactored CtElement2JoinPoint and related converters to support JavaWeaver, ensuring all join point creations are consistent with the new structure. - Adjusted converters for executable, expression, statement, type, and XML node to include JavaWeaver, improving integration and functionality.
…Converters. An explicit entry is now present to ensure the proper joinpoint is created.
Closed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
omen-alpha responding on behalf of @lm-sousa
Problem
The
multi-weaverbranch (weaver-instance refactor: removal ofTHREAD_LOCAL_WEAVER, Weaver engine threading through the joinpoints and node creation methods, CI fixes) had fallen behindmasterand needed a rebase before the lara-4 work on top of it.Solution
Rebased the 5 multi-weaver commits onto the current
mastertip (c8a93d9). All five replayed cleanly (verified withgit range-diff—=on every commit; the only deltas vs the old branch are master-history commits that were already part of the new base).Stack
This is the base of a stack:
master← this PR (multi-weaver) ←lara-4(#51), which migrates the weaver to lara-4/WeaverGen2.