Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 691df915ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ly erasable syntax is allowed - Removed a couple of deprecated files. - Transformed enums into "const" declarations. - Modified the tsconfig.json files - Updated to TS 6 while I was at it.
Since we do not transpile TS anymore, the sources have been moved to their old destination folders.
…ild script in package.json
The problem stems from the requirement of Node.js of "rewriteRelativeImportExtensions" to be "true".
This causes any import that refers to the package name ("@specs-feup/lara/...") to throw a compilation error when compiling Lara-JS.
However, if we rewrite them to use relative imports, the Jest config in the downstream weavers will error out.
Thus, we added directives for the Typescript compiler to ignore the errors in these particular lines.
The ignore directives were of the appropriate scope as to avoid compilation errors in Lara-JS and in the downstream weavers' compilations.
|
Note omen-alpha responding on behalf of @lm-sousa The two S1763 "Unreachable code" findings in |
Remove dead break statements flagged by SonarCloud (S1763) in convert-joinpoint-specification.ts, and add explicit .js -> .ts export patterns so legacy subpath imports like @specs-feup/lara/api/lara/util/Accumulator.js keep resolving after the native-TypeScript migration (found by Codex review).
|
No description provided.