Skip to content

Vitest - #109

Merged
lm-sousa merged 0 commit into
dumper-v3from
vitest
Sep 2, 2026
Merged

Vitest#109
lm-sousa merged 0 commit into
dumper-v3from
vitest

Conversation

@lm-sousa

Copy link
Copy Markdown
Member

No description provided.

Copilot AI lite review requested due to automatic review settings August 28, 2026 20:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 131659dd2e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Lara-JS/vitest/weaverVitestConfig.ts Outdated
Comment on lines +27 to +29
new URL("./weaverEnvironment.ts", import.meta.url),
),
environmentOptions,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep code-only tests out of the Weaver environment

When npm run test:code is run from a clean checkout without DefaultWeaver/build/install/DefaultWeaver, this environment calls Weaver.setupWeaver before running even plain Node tests such as code/ChildProcessHandling.test.ts; setupJavaEnvironment then performs readdirSync on the missing distribution and the suite fails before collecting tests. The removed code/jest.config.ts explicitly used the Node environment, so preserve a separate Node project/environment for code-only tests rather than applying the Weaver environment globally.

Useful? React with 👍 / 👎.

@lm-sousa
lm-sousa merged commit e30b232 into staging Sep 2, 2026
2 checks passed
@sonarqubecloud

sonarqubecloud Bot commented Sep 2, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants