Skip to content

Add stacked PR resilience to the CI workflow - #112

Open
lm-sousa wants to merge 4 commits into
masterfrom
ci-fix
Open

lm-sousa wants to merge 4 commits into
masterfrom
ci-fix

Conversation

@lm-sousa

@lm-sousa lm-sousa commented Sep 3, 2026

Copy link
Copy Markdown
Member

No description provided.

Copilot AI lite review requested due to automatic review settings September 3, 2026 00:13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The PR title indicates CI workflow changes, but the diff only updates Lara-JS/package.json, so the scope/metadata needs to be corrected or the intended CI changes added.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This pull request updates the Lara-JS npm package metadata for @specs-feup/lara, including a package version bump and an updated dependency, which affects the published JavaScript/TypeScript API distribution within the LARA framework.

Changes:

  • Bump @specs-feup/lara version from 3.5.0 to 3.5.1
  • Update the java dependency from ^0.16.1 to ^0.18.0
File summaries
File Description
Lara-JS/package.json Bumps package version and updates the java bridge dependency version.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread Lara-JS/package.json
# Conflicts:
#	.github/workflows/nightly.yml
GitHub does not fire the pull_request event when the synthetic merge
ref cannot be created, which silenced CI for conflicted PRs. The
workflow never used the merge ref anyway: branch pushes report the same
head-SHA checks to the PR's Checks tab. Skip runs for branch deletions,
where the event SHA falls back to the default branch and would mislead
the branch resolver.
@sonarqubecloud

sonarqubecloud Bot commented Sep 3, 2026

Copy link
Copy Markdown

@lm-sousa

lm-sousa commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

Note

glm-5.3-flash responding of behalf of @lm-sousa

Dismissing Copilot's review: the PR does contain the CI workflow changes its title describes — .github/workflows/nightly.yml (nightly now triggers on branch pushes instead of pull_request) and .github/workflows/copilot-setup-steps.yml. The review appears to have inspected only the head commit, whose sole change is a redundant Lara-JS/package.json version bump (its content already matches master). Replied and resolved inline.

@sonarqubecloud

sonarqubecloud Bot commented Sep 4, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants