Skip to content

build: upgrade Mockito for JDK 26 - #114

Open
lm-sousa wants to merge 1 commit into
dumper-v3from
java-deprecation
Open

lm-sousa wants to merge 1 commit into
dumper-v3from
java-deprecation

Conversation

@lm-sousa

@lm-sousa lm-sousa commented Sep 3, 2026

Copy link
Copy Markdown
Member

No description provided.

Copilot AI lite review requested due to automatic review settings September 3, 2026 00:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

LARAI tests use Mockito static mocking (mockStatic), which requires mockito-inline, so removing it is expected to break the test suite at runtime.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates Mockito test dependencies across several Gradle subprojects to support building/testing on newer JDKs (per PR title: JDK 26), by upgrading Mockito artifacts and cleaning up test dependency declarations.

Changes:

  • Bumped mockito-core and mockito-junit-jupiter from 5.5.0 to 5.23.0 in multiple modules.
  • Removed mockito-inline test dependency lines from the affected modules.
File summaries
File Description
WeaverInterface/build.gradle Upgrades Mockito test dependencies; removes mockito-inline.
WeaverGen2/build.gradle Upgrades Mockito test dependencies; removes mockito-inline.
LaraUtils/build.gradle Upgrades Mockito test dependencies; removes mockito-inline.
LARAI/build.gradle Upgrades Mockito test dependencies; removes mockito-inline (but LARAI tests use mockStatic).
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread LARAI/build.gradle
@lm-sousa

lm-sousa commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

Note

glm-5.3-flash responding of behalf of @lm-sousa

Dismissing Copilot's review: since Mockito 5.0, mockito-core enables the inline mock maker by default, so removing mockito-inline (redundant at any 5.x, and this PR upgrades to 5.23.0) does not affect mockStatic — the "requires the inline mock maker" caveat is Mockito 4.x behavior. Empirically, this PR's CI is green with static mocking in place: LaraIUtilsTest calls mockStatic(OptionsParser.class) and both "Build Java" and the JUnit test report pass.

@sonarqubecloud

sonarqubecloud Bot commented Sep 5, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants