chore: fix codeql security alerts - #112
Merged
Merged
Conversation
spelech
force-pushed
the
chore/codeql-fixes
branch
from
August 22, 2026 17:24
46a26a6 to
bfbd865
Compare
added 18 commits
August 22, 2026 12:27
…ng test requirements
… providers - Relax strict HTTPS requirement for localhost and internal container network addresses in Provider config. - Ensure TestVaultConnection endpoint validates HTTP URLs against the same secure requirements. - Add tests to verify HTTP URL validation logic in ProvidersControllerTests. - Update SecretProvidersTab UI to display the specific backend validation error message when saving fails.
spelech
force-pushed
the
chore/codeql-fixes
branch
from
August 22, 2026 17:31
bfbd865 to
ca16035
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| var sessionId = Guid.NewGuid().ToString("N"); | ||
| logger.LogInformation("New Admin SSE connection ({Method}). SessionId: {SessionId}, User: {User}", | ||
| httpContext.Request.Method, sessionId, callerUsername); | ||
| httpContext.Request.Method, sessionId, System.Net.WebUtility.UrlEncode(callerUsername)); |
| var sessionId = Guid.NewGuid().ToString("N"); | ||
| logger.LogInformation("New Admin SSE connection ({Method}). SessionId: {SessionId}, User: {User}", | ||
| httpContext.Request.Method, sessionId, callerUsername); | ||
| httpContext.Request.Method, sessionId, System.Net.WebUtility.UrlEncode(callerUsername)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes several CodeQL security alerts including log-forging, cleartext storage of sensitive information, missing X-Frame-Options, and path-injection. Version bumped to 4.28.1.