Skip to content

vehicles: add px4 sih quadx - #25

Merged
spencerfolk merged 1 commit into
spencerfolk:mainfrom
mrpollo:mrpollo/px4
Nov 5, 2025
Merged

vehicles: add px4 sih quadx#25
spencerfolk merged 1 commit into
spencerfolk:mainfrom
mrpollo:mrpollo/px4

Conversation

@mrpollo

@mrpollo mrpollo commented Jul 5, 2025

Copy link
Copy Markdown
Contributor

Basic implementation of PX4 SITL SIH QUADX, using the defaults from the 10040_sihsim_quadx airframe in PX4.

$ python examples/basic_usage_px4.py
-------------------RESULTS-----------------------
SIM TIME -- 30.00 seconds | WALL TIME -- 2.50 seconds
EXIT STATUS -- Timeout: Simulation end time reached.
Done—PX4 SITL ran for 3001 steps

Signed-off-by: Ramon Roche <mrpollo@gmail.com>
@mrpollo

mrpollo commented Jul 5, 2025

Copy link
Copy Markdown
Contributor Author

@spencerfolk it's a very primitive interface, still needs more love, but can be extended over time. I would appreciate your help with a thorough review. I'm not much of a sim person.

@spencerfolk spencerfolk left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing @mrpollo !!

It looks like we still need to translate the RotorPy sensor data into a format that PX4 likes. A similar method was implemented for the Arudpilot SITL interface

RotorPy has a 6 axis IMU sensor for computing noisy accelerations and body rates.

One minor thing: for consistency can you move the vehicle params dict sihsim_quadx to a separate file and import it in the basic usage script? For example: CF, CFBL, and Hummingbird.

Happy to help if needed. I'm also wondering if there is any desire to model more complex aero like rotor drag or blade flapping for the PX4 SIH quad. But for that we'd need some data.

@Tuxliri

Tuxliri commented Jul 17, 2025

Copy link
Copy Markdown
Contributor

@mrpollo when using the PX4 SITL SIH QUADX is the physics being simulated inside the PX4 firmware? If so then wouldn't this clash with the simulation in rotorpy itself when updating the state and sensors?

@Tuxliri Tuxliri mentioned this pull request Sep 2, 2025
@spencerfolk
spencerfolk merged commit 7b03f52 into spencerfolk:main Nov 5, 2025
@mrpollo

mrpollo commented Nov 6, 2025

Copy link
Copy Markdown
Contributor Author

@Tuxliri, I don't think we are simulating the physics, but I haven't looked into this. Maybe @MaEtUgR can chime in?

@Tuxliri

Tuxliri commented Nov 9, 2025

Copy link
Copy Markdown
Contributor

@Tuxliri, I don't think we are simulating the physics, but I haven't looked into this. Maybe @MaEtUgR can chime in?

I delved a bit more into it, it is being simulated when running the SIH module. I ended up reusing rotorpy's own physics engine in PR #26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants