feat: export DefaultDecodeHook for composition#2141
Open
Solaris-star wants to merge 1 commit into
Open
Conversation
WithDecodeHook / DecodeHook replace Viper's built-in duration and weak string-to-slice hooks entirely. Export DefaultDecodeHook so apps can compose custom hooks without silently losing those defaults (spf13#2139). Fixes spf13#2139
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WithDecodeHook/DecodeHookreplace Viper's built-in mapstructure hooks entirely. The default weak string-to-slice hook is unexported, so apps that add a custom hook silently lose duration/slice conversions and cannot restore them (#2139).Fix
Export
DefaultDecodeHook()and use it as the internal default so callers can compose:Tests
Fixes #2139