Simplify backend: remove Result types, streamline controllers, fix races#48
Merged
Conversation
spicycoder
commented
Jun 20, 2026
spicycoder
commented
Owner
- Replace 6 Result discriminated unions with Room? return types
- RoomController: try/catch for domain exceptions instead of switch-on-result
- PlayerConnectionTracker: single-instance, lock Join/Leave, fix scope disposal
- Remove PostgreSQL URI parser from Program.cs
- Clean up Bootstrap.cs (params Assembly[] -> Assembly?)
- Remove dead code from ServiceDefaults/Extensions
- Remove _ = ct discards from RoomRepository
- Fix PokerHub: group join inside validation block
- Fix integration test: 400 -> 404 for id=0
- Frontend: handle 409 Conflict in JoinRoomForm
- Replace 6 Result discriminated unions with Room? return types - RoomController: try/catch for domain exceptions instead of switch-on-result - PlayerConnectionTracker: single-instance, lock Join/Leave, fix scope disposal - Remove PostgreSQL URI parser from Program.cs - Clean up Bootstrap.cs (params Assembly[] -> Assembly?) - Remove dead code from ServiceDefaults/Extensions - Remove _ = ct discards from RoomRepository - Fix PokerHub: group join inside validation block - Fix integration test: 400 -> 404 for id=0 - Frontend: handle 409 Conflict in JoinRoomForm - All handlers return 'saved' consistently - StatsCard bars capped at 100% to prevent overflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.