Skip to content

add delete to builder #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jimmypuckett merged 2 commits into from
Apr 6, 2025
Merged

add delete to builder #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a67738
Delete need the id in the path
jimmypuckett Apr 6, 2025
a3558bf
Allow deleting id via builder
jimmypuckett Apr 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/Support/Builder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,19 @@ public function debug(bool $debug = true): self
return $this;
}

/**
* Delete specific instance of class
*
* @throws NoClientException
* @throws TokenException
*/
public function delete(int|string $id): bool
{
// TODO: Consider allowing $id to be null & deleting all
return $this->make([$this->getModel()->getKeyName() => $id])
->delete();
}

/**
* Get Collection of class instances that match query
*
Expand Down
2 changes: 1 addition & 1 deletion src/Support/Model.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ public function delete(): bool

try {
$this->getClient()
->delete($this->getPath());
->delete($this->getPath($this->getKey()));

return true;
} catch (GuzzleException $e) {
Expand Down
Loading