Updates for latest cargo-component version#110
Merged
rylev merged 2 commits intospinframework:mainfrom Jul 11, 2024
Merged
Conversation
Contributor
Author
rylev
approved these changes
Jul 11, 2024
Collaborator
rylev
left a comment
rylev
left a comment
There was a problem hiding this comment.
This looks great! Thanks 👍
v0.14.0 of cargo-component requires the `wasm32-wasip1` target, which is only available in Rust versions 1.78.0 and later. This updates the `RUST_VERSION`, the target name, as well as pins the `CARGO_COMPONENT_VERSION` to hopefully avoid an issue like this in the future. Signed-off-by: Ben Brandt <benjamin.j.brandt@gmail.com>
auto-merge was automatically disabled
July 11, 2024 11:13
Head branch was pushed to by a user without write access
benbrandt
force-pushed
the
update-cargo-component
branch
from
b06f99e to
dbbefe9
Compare
Contributor
Author
|
@rylev just ran into this on another project... not all of the tooling has transitioned to the new target... so we in fact need both it seems for now until the transition is complete. |
Collaborator
|
Indeed, this is annoying as the underlying reason we can't fully transition to |
Collaborator
|
@benbrandt can you update the release workflow as well? |
Signed-off-by: Ben Brandt <benjamin.j.brandt@gmail.com>
benbrandt
force-pushed
the
update-cargo-component
branch
from
51b09d9 to
954eba4
Compare
Contributor
Author
|
@rylev good catch. Let me know if it looks ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.14.0 of cargo-component requires the
wasm32-wasip1target, which is only available in Rust versions 1.78.0 and later.This updates the
RUST_VERSION, the target name, as well as pins theCARGO_COMPONENT_VERSIONto hopefully avoid an issue like this in the future.