Postgres fallback port resolution fix#3398
Open
itowlson wants to merge 1 commit intospinframework:mainfrom
Open
Postgres fallback port resolution fix#3398itowlson wants to merge 1 commit intospinframework:mainfrom
itowlson wants to merge 1 commit intospinframework:mainfrom
Conversation
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
itowlson
force-pushed
the
postgres-less-misleading-error-could-muddle-port-maybe
branch
from
67ffb2a to
ed5726a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lann spotted a possible error in the way we resolve Postgres ports for error reporting.
In practice I can't actually get the scenario to happen so maybe it occurs only on connection strings more eccentric than those I came up with, but it at least avoids surprising code.