fix(ci): pin xmake Windows runner to windows-2022 - #464
Merged
Conversation
The windows-2025 runner image was updated with MSVC 14.51 (VS 2026), which causes nvcc cudafe++ ACCESS_VIOLATION crashes and fmt warning promotions. Pin to windows-2022 (MSVC 14.44) until CUDA toolkit supports the newer compiler. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin the xmake CI Windows runner from
windows-2025towindows-2022.GitHub recently updated the
windows-2025runner image, bumping the pre-installed MSVC from 14.44.35207 (VS 2022) to 14.51.36231 (VS 2026/18). This breaks the xmake CI build with two errors:cudafe++ACCESS_VIOLATION — CUDA 12.8's frontend crashes when paired with MSVC 14.51 (e.g. onactive_set_reporter.cu).fmt/format.hwarnings promoted to errors —fmt 12.1.0Unicode literals that were benign warnings under MSVC 14.44 become fatal under the new toolchain.The cmake CI already uses
windows-2022and is unaffected. This change aligns the xmake CI to the same runner until NVIDIA ships a CUDA toolkit update that supports the newer compiler.Evidence
windows-2025used MSVC 14.44 → CI passedwindows-2025now uses MSVC 14.51 → CI failed (same code, different runner image)