Remove completed venue-island migration tooling (#138)

[spizeck]

Summary

The one-time migrate:venue-islands backfill introduced in #134 has been applied to all production venue documents, so its machinery is now disposable. This PR removes the migration script, its npm command, the migration-only resolveVenueGeography() helper (verified dead — nothing outside the script referenced it), the migration-mapping unit tests, and docs that presented the command as an active operational tool.

Canonical island/locality behavior is unchanged: Venue.island, lib/venue-islands.ts, canonical grouping/filtering, the admin island selector, Firestore island validation, card locality composition, and the transitional legacy locationName read fallback all remain.

Closes #138

Changes

• Deleted scripts/migrate-venue-islands.ts (dry-run/--write backfill script)
• Removed the migrate:venue-islands entry from package.json and the README command table
• Removed resolveVenueGeography(), VenueGeography, and KNOWN_LOCALITY_ISLANDS from lib/venue-filters.ts — dead code once the script was gone (admin still uses resolveVenueIsland, which is kept)
• Removed the resolveVenueGeography (migration mapping) describe block (7 tests) from tests/lib/venue-filters.test.ts
• docs/TECHNICAL.md: dropped the script from the scripts/ listings; reworded the fallback note — reads fall back to locationName for legacy documents, not "until the backfill completes"
• docs/admin/managing-locations.md + lib/types.ts + lib/venue-filters.ts comments: reworded "until migration completes" wording now that the migration is done; the documented fallback semantics are unchanged
• No changes to firestore.rules, venue behavior, admin UI, analytics, or fixtures

Verification

• npm ci
• npm run check:react-versions
• npx tsc --noEmit
• npm run lint (exit 0; pre-existing TSSatisfiesExpression notice unchanged)
• npm test — 372 pass (−7 intentionally removed migration-mapping tests)
• npm run test:rules — 30 pass; venue island allowlist still enforced
• npm run build
• npm run test:smoke — 131 Playwright tests pass
• npm run check:md-links
• npm audit --omit=dev — 0 vulnerabilities
• npm run no longer lists migrate:venue-islands

Risk / deployment notes

None. No production data touched and no behavior changed — this only removes a completed one-time migration script, its dead helper, and stale doc references. The legacy locationName read fallback intentionally remains for any stale records/environments.

Generated with Devin

Summary by Sourcery

Retire the completed venue-island backfill machinery and update references to reflect the migration’s completion.

Enhancements:

• Remove the completed venue-island migration tooling and its now-unused geography mapping code while retaining canonical island behavior and legacy read fallbacks.

Documentation:

• Update technical and admin documentation to remove the migration command and describe legacy fallback behavior as ongoing compatibility support.

Tests:

• Remove unit tests dedicated to the retired migration mapping helper.

[sourcery-ai]

Sorry @spizeck, this account has used its review budget of 1,500,000 diff characters for the last 7 days.

You can request another review in 2 hours and 51 minutes by commenting @sourcery-ai review. Upgrade to get a review now.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
deepdivebrewing-web	Ready	Preview	Sep 24, 2026 3:28pm UTC

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR retires the completed venue-island migration by deleting its script, command, migration-only resolver, and dedicated tests, while updating stale documentation and preserving all canonical island behavior and legacy locationName read fallback.

File-Level Changes

Change	Details	Files
Removed the completed venue-island backfill tooling and its public entry points.	Deleted the dry-run/--write migration script. Removed the npm script and README/technical documentation references. Updated script listings to reflect the remaining local tooling.	scripts/migrate-venue-islands.ts package.json README.md docs/TECHNICAL.md
Removed migration-only geography resolution code and tests while preserving runtime venue-island behavior.	Deleted resolveVenueGeography, VenueGeography, and KNOWN_LOCALITY_ISLANDS. Removed the seven migration-mapping test cases. Kept canonical island resolution, grouping, filtering, admin selection, and legacy read fallback intact.	lib/venue-filters.ts tests/lib/venue-filters.test.ts
Reworded documentation and type comments to describe the post-migration legacy fallback state.	Changed migration-in-progress wording to identify legacy documents as the fallback scope. Clarified that stale records remain readable without implying further backfill work.	docs/TECHNICAL.md docs/admin/managing-locations.md lib/types.ts lib/venue-filters.ts

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#138	Remove the completed venue-island migration tooling, including the migration script, npm command, migration-only geography helper, and its migration-specific tests.	✅
#138	Remove or update README, technical documentation, and admin documentation that present the venue-island migration as an active or incomplete operational process.	✅
#138	Preserve the canonical venue island/locality behavior and transitional legacy locationName read fallback, including grouping/filtering, admin selection, Firestore validation, and card locality composition.	✅

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.