ci: gate test jobs by changed domain - #181
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Reviewer's GuideIntroduces a fail-safe Detect changes job in the website test workflow that validates and classifies changed files into app and performance domains, then gates the corresponding Playwright jobs with job-level conditions while retaining full runs for master pushes, manual dispatches, and uncertain changes. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
Website testschange-aware. A newDetect changesjob diffs the PR againstmaster, classifies changed paths intoappandperfdomains, and gatesCritical website testsandPerformance budgetswith a job-levelif:. Pushes tomasterand manual dispatch still run both.Previously a docs-only PR booted two Playwright-container jobs —
npm ci, coverage run, test build, full E2E suite, and the performance baseline.Check safety
Gating uses job-level
if:, not workflowpaths:filters: a skipped job reports Success and satisfies required checks, whereas a filtered workflow would leave them pending forever. The classifier fails safe: uncomputable diff or unrecognized path → run everything. Cheap JSON/YAML validation runs insideDetect changes.patches/**(patch-package) always runs everything.Expected behavior
*.md,.github/**,vercel.json,.vscode/**app/**,components/**,lib/**,public/**,next.config.*tests/**,playwright.config.ts,eslint*,vitest.config.mts,scripts/**perf/**,scripts/perf-*,scripts/build-test.mjspatches/**(postinstall patches)package.json/package-lock.json/.nvmrcmasterproduction-smoke.ymlis untouched — it is deployment/schedule-triggered, not per-PR.Validation
Classifier logic exercised locally against simulated diffs. Workflow YAML validated.
Generated with Devin
Summary by Sourcery
Make website CI change-aware by selectively running critical and performance checks while retaining fail-safe full coverage for broad or uncertain changes.
New Features:
Enhancements:
CI: