Repository navigation
[ports] Support ports that are types and treat string ports conversion properly. - #507
Merged
sea-bass merged 3 commits intoAug 21, 2026
Merged
Conversation
JenniferBuehler
left a comment
JenniferBuehler
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks for the fixes and for adding the new test!
Instead of lenghty comments to suggest changes, I made a PR on your PR: fgrcar#1
Other than this minor things, it looks good to me!
sea-bass
reviewed
Aug 14, 2026
sea-bass
left a comment
sea-bass
left a comment
Member
There was a problem hiding this comment.
Nice change, and thank you for adding tests!
I mostly just have some Python style things to consider.
* suggested improvements * address feedback
sea-bass
approved these changes
Aug 21, 2026
sea-bass
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a couple of things related to the newly added ports and their type application when parsing from XML:
convert_str_to_typeinports_utils.pyhandles that.apply_type_hintsmethod inports_utils.pydefined success based on comparison of the value before vs. after which makes sense for most of the types, but not for the string that remains the same even in case of a success. I addressed that by explicit return of success in all the helper methods.apply_type_hintsfallbacks to that type in case of specific attribute type hint is not present.I added also some tests that cover the port conversions.
Best regards,
fgrcar