fix: cap ruff <0.16 so CI lint stops changing under us - #5
Merged
Conversation
CI has been red on main since 2026-07-26 with 31 ruff violations in code nobody touched. ruff 0.16 moved a large set of opinionated rules (BLE, PLW, TRY, C408, EXE, B017, UP035, ...) into its DEFAULT rule set, and the dev extra asked only for `ruff>=0.5` — so the lint step silently changed what it enforces the moment ruff published. Same cap already applied to airflow-spawn, miniwdl-spawn and snakemake-executor-plugin-spawn; cwl-spawn is the last adapter exposed. Verified locally: ruff resolves to 0.15.22, `ruff check .` passes, `mypy cwl_spawn` clean, 31 tests pass. Nothing was hidden behind the lint abort.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI has been red on
mainsince 2026-07-26 (run 30188341549) with 31 ruffviolations in code nobody touched.
Cause: ruff 0.16 moved a large set of opinionated rules (
BLE,PLW,TRY,C408,EXE,B017,UP035, …) into its default rule set. The dev extraasked only for
ruff>=0.5, soruff check .silently changed what CI enforcesthe moment ruff published.
Fix: cap
ruff>=0.5,<0.16, with a comment explaining why raising it should bedeliberate (adopt rules via an explicit
[tool.ruff.lint] select, don't inheritwhatever a release decides).
This is the same break already fixed in
airflow-spawn,snakemake-executor-plugin-spawnandminiwdl-spawn— cwl-spawn was the lastadapter still exposed. Found while auditing the other Python repos after it broke
miniwdl-spawn's CI.Verified locally (all three CI steps, matching
ci.yml):ruff --version→ 0.15.22;ruff check .→ All checks passedmypy cwl_spawn→ Success: no issues found in 6 source filespytest -q→ 31 passedThe lint step aborts the job before mypy/pytest, so it could have been hiding a
second failure (it was in
airflow-spawn). It wasn't here — both were alreadygreen.
python-sdkalso has an unpinnedruff, but its CI never invokes it, so it'sdormant rather than broken; left alone.