feat(sdk): expose remaining launch params (ami/key_name/pre_stop/completion_file) (#6) - #8
Merged
Merged
Conversation
…pletion_file (#6) The REST launch endpoint accepts ami, key_name, pre_stop, completion_file (instances.go), but launch() never surfaced them. Add as optional kwargs, forwarded to the body with the real API keys when set (omitted otherwise). SDK now covers the full launch body — API-complete. Tests assert forwarding + omission. Bump 0.1.4 -> 0.1.5. Closes #6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6. Adds the four launch-body fields the REST endpoint (
handleLaunch, instances.go) accepts butspawn.launch()didn't surface:ami,key_name,pre_stop,completion_file. Optional kwargs, forwarded to the request body with the real API keys when set, omitted otherwise. Purely additive.With this the SDK covers the full launch body — completing API parity (instances + truffle + notifications + all launch params).
Tests: forwarding of all four + omission when unset (19 total). ruff clean, build green. Bump 0.1.4 → 0.1.5.