Skip to content

feat(settings): add option to disable existing file check (#848)#861

Open
SnitchTeam wants to merge 1 commit into
spotbye:mainfrom
SnitchTeam:feat/848-disable-filecheck
Open

feat(settings): add option to disable existing file check (#848)#861
SnitchTeam wants to merge 1 commit into
spotbye:mainfrom
SnitchTeam:feat/848-disable-filecheck

Conversation

@SnitchTeam
Copy link
Copy Markdown

Summary

Adds a third value (none) to the existingFileCheckMode setting, exposed in the Settings UI as Disabled. When selected, the app no longer skips a track because a file with the same name already exists on disk, so the same track can be downloaded into multiple playlist folders.

Behavior

  • filename (default) and isrc modes are unchanged.
  • none short-circuits ResolveOutputPathForDownload to always return (path, false), bypasses the existing-file early returns in the Qobuz, Tidal and Amazon download paths, and disables the _NN suffix renaming.
  • Configs that set the value to off or disabled are normalized to none for forward-compatibility.

Test notes

  • go build ./... and go vet ./backend/... pass.
  • Manual: with the option set to Disabled, downloading a playlist that contains a track already on disk re-downloads the file instead of skipping it. With Filename or ISRC the previous behavior is preserved.

Closes #848

Allows downloading the same track into multiple playlist folders by bypassing the os.Stat-based skip in qobuz/tidal/amazon and ResolveOutputPathForDownload. Existing 'filename' and 'isrc' modes are unchanged.

Closes spotbye#848
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Let me disable filecheck

1 participant