feat(settings): add option to disable existing file check (#848)#861
Open
SnitchTeam wants to merge 1 commit into
Open
feat(settings): add option to disable existing file check (#848)#861SnitchTeam wants to merge 1 commit into
SnitchTeam wants to merge 1 commit into
Conversation
Allows downloading the same track into multiple playlist folders by bypassing the os.Stat-based skip in qobuz/tidal/amazon and ResolveOutputPathForDownload. Existing 'filename' and 'isrc' modes are unchanged. Closes spotbye#848
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a third value (
none) to theexistingFileCheckModesetting, exposed in the Settings UI as Disabled. When selected, the app no longer skips a track because a file with the same name already exists on disk, so the same track can be downloaded into multiple playlist folders.Behavior
filename(default) andisrcmodes are unchanged.noneshort-circuitsResolveOutputPathForDownloadto always return(path, false), bypasses the existing-file early returns in the Qobuz, Tidal and Amazon download paths, and disables the_NNsuffix renaming.offordisabledare normalized tononefor forward-compatibility.Test notes
go build ./...andgo vet ./backend/...pass.Closes #848