upd #1
Open
upd #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khramov86
requested changes
Apr 20, 2022
Collaborator
khramov86
left a comment
khramov86
left a comment
There was a problem hiding this comment.
Необходимо исправить замечания
| except AttributeError: | ||
| lfm = None | ||
| try: | ||
| date_and_city_of_birth = soup.find("div", class_="reestr").find('p').text.strip() |
Collaborator
There was a problem hiding this comment.
Возможно имеет смысл сделать парсинг этих полей так же через parse_table для единообразия.
| all_rows_len = len(all_rows) | ||
| bar = IncrementalBar('Getting user info', max = all_rows_len) | ||
|
|
||
| for index, row in enumerate(all_rows): |
Collaborator
There was a problem hiding this comment.
Переменная index нигде не используется, возможно не нужен enunmerate?
| if not user_parsed_data['lfm']: | ||
| error_list.append((href_obj.text, url)) | ||
| continue | ||
| person_list.append(user_parsed_data) |
Collaborator
There was a problem hiding this comment.
В данных есть пользователи без нормальных ФИО. Необходимо подумать, может быть сделать проверку на пропуск таких пользователей и так же отображать в stdout/log их
if len(lfm.split(' ')) < 2:
continue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.