Upgrade to draftail#29
Conversation
This hack was introduced to allow wagtailfontawesome icons to render with <span> tags, but it's kind of horrible so I'm pulling it out in favour of just using upstream wagtail icons for now.
aaronhaslett
force-pushed
the
upgrade_to_draftail
branch
from
60d14dd to
69e98aa
Compare
|
@liamjohnston to Typescriptify JS code. No need to TSify the components folder, just the stuff I wrote. These files: |
aaronhaslett
force-pushed
the
upgrade_to_draftail
branch
from
69e98aa to
293de7b
Compare
DB conversion rules to support new wagtail's markup DB format
aaronhaslett
force-pushed
the
upgrade_to_draftail
branch
from
293de7b to
979d33c
Compare
aaronhaslett
force-pushed
the
upgrade_to_draftail
branch
from
979d33c to
09fc19f
Compare
aaronhaslett
force-pushed
the
upgrade_to_draftail
branch
from
09fc19f to
cd610a0
Compare
| entityKey: string; | ||
| contentState: any; | ||
| children: React.ReactNode; | ||
| }; |
There was a problem hiding this comment.
Should be available in draft-js types which you already added to package.json https://github.com/facebook/draft-js/blob/74ebc510be96c5d850bde71f5e9f609636fd304f/src/model/decorators/DraftDecorator.js#L54
There was a problem hiding this comment.
oh also i think you missed draftailmodelchoosers.js
There was a problem hiding this comment.
also i rewrote the history a bit. do this:
git fetch
git checkout upgrade_to_draftail
git reset origin/upgrade_to_draftail --hard
There was a problem hiding this comment.
@liamjohnston if you already started work before doing the above then tell me - we'll sort it out.
There was a problem hiding this comment.
unless you're feeling pro at git
There was a problem hiding this comment.
oh also i think you missed draftailmodelchoosers.js
@aaronhaslett whoops! I accidentally did wagtailmodelchoosers.js instead... no harm done I guess? Will do draftailmodelchoosers.js now
aaronhaslett
force-pushed
the
upgrade_to_draftail
branch
from
87c4875 to
8bcb6c6
Compare
Wagtail released 2.13 while I was in the middle of this work and it breaks using templates to insert JS code. Instead, we now use a telepath adapter.
…s that I know about.
aaronhaslett
force-pushed
the
upgrade_to_draftail
branch
from
0851942 to
134bbd6
Compare
I don't know why this is necessary but 2.0.2 wagtail seems to want it
2 participants
No description provided.