Conversation
MakMuftic
reviewed
Aug 9, 2023
Contributor
|
Go Test coverage is 63.6 %\ ✨ ✨ ✨ |
mpetrun5
requested changes
Aug 9, 2023
Collaborator
mpetrun5
left a comment
There was a problem hiding this comment.
Found deposit in core is missing deposit data and handler response.
Collaborator
|
Minor nitpick, but don't really like where ctx is renamed to ctxWithSpan. |
Contributor
|
Go Test coverage is 63.6 %\ ✨ ✨ ✨ |
…actually finishing its execution
9 tasks
Contributor
|
Go Test coverage is 63.5 %\ ✨ ✨ ✨ |
mpetrun5
reviewed
Aug 29, 2023
Contributor
|
Go Test coverage is 63.5 %\ ✨ ✨ ✨ |
Contributor
Author
|
Recent changes require updates from ChainSafe/chainbridge-core#350 |
Contributor
|
Go Test coverage is 64.6 %\ ✨ ✨ ✨ |
Collaborator
|
Closing temporarily. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Traces across the whole repo.
This is highly depended on changes in CORE repo that needs to be released first
Related Issue Or Context
Closes: n/a
How Has This Been Tested? Testing details.
Types of changes
Checklist: