Skip to content

Conversation

@greinerdavid
Copy link

PR Description

AbstractTransfers are used in the spryker/step-engine package, which are a $quoteTransfer according to the annotation and variable name. This leads to misunderstandings and links the step engine to the checkout. However, as the step engine can also be used for other multi-step forms (wizards) independently of the checkout, it should not be linked to the checkout in the wording.

Steps before you submit a PR

  • Please add tests for the code you add if it's possible.
  • Please check out our contribution guide: https://docs.spryker.com/docs/dg/dev/code-contribution-guide.html
  • Add a contribution-license-agreement.txt file with the following content:
    I hereby agree to Spryker\'s Contribution License Agreement in https://github.com/spryker/step-engine/blob/HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCH/CONTRIBUTING.md.

This is a mandatory step to make sure you are aware of the license agreement and agree to it. HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCH is a hash of the commit you are basing your branch from the master branch. You can take it from commits list of master branch before you submit a PR.

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

@spryker-release-bot
Copy link
Collaborator

Dear contributor,

Your pull request will be reviewed by our team. In the meantime, please ensure that the PR complies with Spryker's coding guidelines and that your changes are covered by tests.

Thank you very much for your contribution to the development of Spryker and the growth of the Spryker community!

…ic $abstractTransfer to reflect abstract transfer usage
@greinerdavid greinerdavid force-pushed the task/replace-misleading-quote-transfer-wording branch from 9074246 to be61daa Compare May 12, 2025 06:34
@matweew
Copy link
Contributor

matweew commented Jun 10, 2025

Released in https://github.com/spryker/step-engine/releases/tag/3.7.0. Could you please close the PR.

@greinerdavid
Copy link
Author

@matweew thank you very much. I closed the pr now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants