Guard release script against mismatched tags#623
Merged
Conversation
johnnewman-square
approved these changes
Jun 17, 2026
johnnewman-square
left a comment
Contributor
There was a problem hiding this comment.
This looks good. Thanks for making this tweak!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gh release createruns.Feedback Addressed
Addresses the concern from #622 (comment). The review was valid:
gh release create --targetonly affects auto-created tags, so an existing tag without a release could have caused the release to be created from a different commit than the script printed.Validation
bash -n Scripts/release.shScripts/release.sh --version 9.9.9 --dry-run --no-openScripts/release.sh --version 6.7.2 --target origin/main --dry-run --no-openfails with the new mismatched-tag errorScripts/release.sh --version 6.7.2 --target 6.7.2 --dry-run --no-openreaches the existing-release guardgit diff --checkshellcheckis not installed locally.