Adopt verified remote routes without redeploying - #45
Merged
Merged
Conversation
Signed-off-by: squarepots <46488165+squarepots@users.noreply.github.com>
Signed-off-by: squarepots <46488165+squarepots@users.noreply.github.com>
Signed-off-by: squarepots <46488165+squarepots@users.noreply.github.com>
Signed-off-by: squarepots <46488165+squarepots@users.noreply.github.com>
Signed-off-by: squarepots <46488165+squarepots@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
in-syncpreflight audit as completed remote deployment and adopt that state locally instead of mutating the host againservice-missingstate while the Route is still pending/deployingWhy
PR #41 made every deployment retry audit first, but still allowed
in-syncto continue intoperformRouteOperation, which could redeploy a Route whose remote mutation had already succeeded. That violates #7 acceptance criterion 3: a local persistence failure after successful remote deployment must recover without redeploying blindly.Version impact
patch —
2.2.2→2.2.3Closes #7