Fixed bad construction of class attributes in meta-class (fixes #138) #140
Conversation
ChrisTimperley
changed the title
…ix-dynamic-properties
| Idle: if the conditions above cannot be met, the robot will ignore the | ||
| command. | ||
| """ | ||
| uid = 'ardu:common:arm' |
There was a problem hiding this comment.
Probably better idea to add this property for all commands in the same PR.
There was a problem hiding this comment.
Definitely. I was expecting the CI to spot any commands with missing properties, but maybe it's missed some?
|
@ChrisTimperley And this one 😉 |
|
It looks like there might be a bug or two in this. You might want to take a look at the Travis build output. |
|
Oh, wait, I wrote this, haha. I think Travis/GH was down when I created this PR. I'll look into it. |
|
@afsafzal the problem seems to be that the commands that are dynamically created by the Ardu command factory don't provide a |
|
@ChrisTimperley No that's the id specified by MAVLink. We need to dynamically generate the |
2 participants
No description provided.