Skip to content

det: run START/RETRIEVE and TS/TD queue areas over a COMP-5 group in Java under zos_comp5 (Part of #7845, #7709) - #7936

Merged
squid-shepherd[bot] merged 3 commits into
mainfrom
churn/7845-20261106T1831Z
Nov 6, 2026
Merged

squid-shepherd[bot] merged 3 commits into
mainfrom
churn/7845-20261106T1831Z

Conversation

@squid-protocol

Copy link
Copy Markdown
Owner

Part of #7845, #7709.

Checklist: done [c:fd1805c2]

What

Checks the siblings of the container fix: START FROM / RETRIEVE INTO and WRITEQ / READQ TS and TD. #7878 pinned that they translate under zos_comp5; this runs them. test_det_zos_comp5_queue_run_7845.py pushes a text + S9(4) / S9(9) / S9(18) COMP-5 group through the generated runtime sequence (DetCics.toRegion / fromRegion around CicsTask TS, the TD String record, startData for START) with the region page equal to the program's and with cp037.

Result: the values read back are the same in every case. The stored image is IBM's big-endian bytes when the pages are equal, and for TD. With a different region page, the TS item and START data hold the bytes transcoded one by one. No code change: the pages are a run-time property (CobolRecords.charset(), gitgalaxy.cics.charset), so a translate-time refusal would over-refuse, and the values survive. C7.md records the boundary.

Class / Sibling gaps

Class: zos_comp5 byte stores where the runtime holds program bytes (SQLCA, COMMAREA, containers done in #7841 / #7865 / #7868 / #7933; this PR: START / RETRIEVE, TS, TD checked and run).
Sibling gaps:

  • Comparator reversal of queue / START bytes (comp5_byte_order has container_layouts for containers only). Status: missing. No burned program needs it (SEQPNT, ASYNCPNT, PAUDBLOD, PAUDBUNL, DBUNLDGS issue no START / RETRIEVE / WRITEQ / READQ). Scope: sweep, only if a burned program comes to need it.
  • TS / START stored image transcoded under a differing region page: frontier, no burned program.
  • Foreign CALL, CEE* / DSNTIAC: refused by design (LE / Db2 runtime reads COMP-5 little-endian).
  • Re-survey of the 3 census programs ([c:884b987d]): census clones, tool-counted, not here.

Facts checked: the five comp5_byte_order burned cases hold no START / RETRIEVE / WRITEQ / READQ; audit_check.py clear; new test and the container tests pass (det extras installed).

🤖 Generated with Claude Code

…Java under zos_comp5 (Part of #7845, #7709)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@squid-protocol squid-protocol added the shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md label Nov 6, 2026
@squid-shepherd

squid-shepherd Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@squid-shepherd
squid-shepherd Bot marked this pull request as ready for review November 6, 2026 18:53
@squid-shepherd
squid-shepherd Bot enabled auto-merge (squash) November 6, 2026 18:55
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@squid-shepherd

squid-shepherd Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@squid-shepherd
squid-shepherd Bot disabled auto-merge November 6, 2026 19:11
@squid-shepherd

squid-shepherd Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

PR #7936 @ e784650: 1 failed check(s)

== ground-truth part 2/4 (failure) -- real
https://github.com/squid-protocol/gitgalaxy/actions/runs/42276479950/job/128094328594
repro: python -m pytest -q tests/cobol_mainframe/test_cobolrt_api.py::test_the_manifest_is_the_sources_surface
failing tests: tests/cobol_mainframe/test_cobolrt_api.py::test_the_manifest_is_the_sources_surface
errors:
fail-on-cache-miss: false
tests/cobol_mainframe/test_cobolrt_api.py:109: AssertionError
FAILED tests/cobol_mainframe/test_cobolrt_api.py::test_the_manifest_is_the_sources_surface - assert ["the manifes....py generate"] == []
##[error]Process completed with exit code 1.
log tail:
env:
GITGALAXY_LICENSE_KEY: COMMUNITY_FREE_TIER
GITGALAXY_MAINFRAME_CORPORA: /home/runner/work/gitgalaxy/gitgalaxy/.mainframe_corpora
MAINFRAME_ENGINE_KEY: a935b70bdc7c1ae70809869353f08342d13d8d6014cc9e7c42f9d180ef5a33bc
PYTHONUTF8: 1
pythonLocation: /opt/hostedtoolcache/Python/3.12.16/x64
PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.12.16/x64/lib/pkgconfig
Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.16/x64
Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.16/x64
Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.16/x64
LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.12.16/x64/lib
##[endgroup]
With the provided path, there will be 1 file uploaded
Artifact name is valid!
Root directory input is valid!
Uploading artifact: test-times-ground-truth-part-2.zip
Beginning upload of artifact content to blob storage
Uploaded bytes 93106
Finished uploading artifact content to blob storage!
SHA256 digest of uploaded artifact is 1e45ebdffa300f7cfb31dccc58d09bc7e29a947e4760bfae9f780de465c99ecc
Finalizing artifact upload
Artifact test-times-ground-truth-part-2 successfully finalized. Artifact ID 13533591931
Artifact test-times-ground-truth-part-2 has been successfully uploaded! Final size is 93106 bytes. Artifact ID is 13533591931
Artifact download URL: https://github.com/squid-protocol/gitgalaxy/actions/runs/42276479950/artifacts/13533591931
Post job cleanup.
[command]/usr/bin/git version
git version 2.56.0
Temporarily overriding HOME='/home/runner/work/_temp/0ec7ef5c-b908-4f16-8d88-871377a8cb53' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/usr/bin/git config --global --add safe.directory /home/runner/work/gitgalaxy/gitgalaxy/gitgalaxy
Removing SSH command configuration
[command]/usr/bin/git config --local --name-only --get-regexp core.sshCommand
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Removing HTTP extra header
[command]/usr/bin/git config --local --name-only --get-regexp http.https://github.com/.extraheader
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http.https://github.com/.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Removing includeIf entries pointing to credentials config files
[command]/usr/bin/git config --local --name-only --get-regexp ^includeIf.gitdir:
[command]/usr/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
Cleaning up orphan processes

@squid-shepherd squid-shepherd Bot added shepherd:needs-fix Bot: a real failure on this head; see the digest comment. Guide: docs/ci.md shepherd:waiting-on-main Bot: the failing check fails on main too (main's to fix). Guide: docs/ci.md labels Nov 6, 2026
@squid-protocol squid-protocol added shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md and removed shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md labels Nov 6, 2026
@squid-shepherd

squid-shepherd Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@squid-shepherd

squid-shepherd Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@squid-shepherd
squid-shepherd Bot enabled auto-merge (squash) November 6, 2026 19:39
@squid-shepherd squid-shepherd Bot removed shepherd:needs-fix Bot: a real failure on this head; see the digest comment. Guide: docs/ci.md shepherd:waiting-on-main Bot: the failing check fails on main too (main's to fix). Guide: docs/ci.md labels Nov 6, 2026
@squid-shepherd
squid-shepherd Bot merged commit fd21178 into main Nov 6, 2026
41 checks passed
@squid-shepherd
squid-shepherd Bot deleted the churn/7845-20261106T1831Z branch November 6, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant