Skip to content

test: skip the JSON GENERATE SUPPRESS WHEN runtime test when no JDK is present (Closes #7937) - #7940

Merged
squid-shepherd[bot] merged 2 commits into
mainfrom
churn/7937-20261106T1851Z
Nov 6, 2026
Merged

squid-shepherd[bot] merged 2 commits into
mainfrom
churn/7937-20261106T1851Z

Conversation

@squid-protocol

Copy link
Copy Markdown
Owner

Fixes the two Windows legs of Full Suite Gate run 42270165081 (main, 0279ad34a).

What

test_the_runtime_leaves_out_what_suppress_when_selects called _jdk() without a skipif. The Windows legs have no JDK, so _jdk() returned None and jdk / "javac" raised TypeError. It now carries the same skipif as its two siblings in the file.

Class sweep

Class: a JDK-dependent test with no skip guard. An AST walk over every tests/**/test_*.py function that assigns _jdk() found this test as the only unguarded one. Sibling gaps: none.

Verification

  • With the JDK set: 42 passed. With JDK_17 and JAVA_HOME unset: 39 passed, 3 skipped.
  • audit_check.py: all clear. ruff format --check: clean.
  • The Windows legs are not run locally. Confirm with the shepherd:matrix label or a dispatch of the Full Suite Gate on this branch.

Cross-repo: none. Overlaps PRs #7930 and #7938 on the same test file; this change is one added line and merges cleanly with main as of now.

Closes #7937

🤖 Generated with Claude Code

…s present (Part of #7937)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@squid-protocol squid-protocol added the shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md label Nov 6, 2026
@squid-shepherd

squid-shepherd Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@squid-shepherd
squid-shepherd Bot marked this pull request as ready for review November 6, 2026 19:11
@squid-shepherd

squid-shepherd Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@squid-shepherd
squid-shepherd Bot enabled auto-merge (squash) November 6, 2026 19:11
@squid-protocol squid-protocol added shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md and removed shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md labels Nov 6, 2026
@squid-shepherd

squid-shepherd Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@squid-shepherd squid-shepherd Bot added the shepherd:waiting-on-main Bot: the failing check fails on main too (main's to fix). Guide: docs/ci.md label Nov 6, 2026
@squid-shepherd
squid-shepherd Bot disabled auto-merge November 6, 2026 20:00
@squid-shepherd

squid-shepherd Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

PR #7940 @ e2534c9: 2 failed check(s)

== ground-truth (failure) -- real
https://github.com/squid-protocol/gitgalaxy/actions/runs/42277463273/job/128100698431
repro: python tests/tools/pr_gates.py --ratchets --only-ratchets ground-truth (when a ground-truth part failed too, run that part's repro)
errors:
##[error]Process completed with exit code 1.
log tail:
##[endgroup]
##[group]Operating System
Ubuntu
24.04.5
LTS
##[endgroup]
##[group]Runner Image
Image: ubuntu-24.04
Version: 20261101.360.1
Included Software: https://github.com/actions/runner-images/blob/ubuntu24/20261101.360/images/ubuntu/Ubuntu2404-Readme.md
Image Release: https://github.com/actions/runner-images/releases/tag/ubuntu24%2F20261101.360
##[endgroup]
##[group]GITHUB_TOKEN Permissions
Contents: read
Metadata: read
##[endgroup]
Secret source: Actions
Cache mode: write
Prepare workflow directory
Prepare all required actions
Complete job name: ground-truth
##[group]Run echo "ground-truth warm: $WARM, parts: $PARTS (tested-tree skip: $SKIP, plan mode: $MODE, layout: $LAYOUT, warm planned: $PLANNED_WARM)"
echo "ground-truth warm: $WARM, parts: $PARTS (tested-tree skip: $SKIP, plan mode: $MODE, layout: $LAYOUT, warm planned: $PLANNED_WARM)"
# #4935: "skipped" is a pass only when the gate proved this tree green on the PR; otherwise it is a failure
# #5164: ... or when the plan found no ground-truth input in the PR (mode none). An empty mode is not none.
ok() { test "$1" = "success" || { test "$1" = "skipped" && { test "$SKIP" = "true" || test "$MODE" = "none"; }; }; }
# #5543: ... or when the layout needs no warm job (a cache hit on the scans, or the busy layout): the parts then warm for themselves
{ ok "$WARM" || { test "$WARM" = "skipped" && test "$PLANNED_WARM" = "false"; }; } && ok "$PARTS"
shell: /usr/bin/bash -e {0}
env:
WARM: skipped
PARTS: failure
SKIP:
MODE: full
PLANNED_WARM: false
LAYOUT: calm
##[endgroup]
ground-truth warm: skipped, parts: failure (tested-tree skip: , plan mode: full, layout: calm, warm planned: false)
##[error]Process completed with exit code 1.
Cleaning up orphan processes

== ground-truth part 3/4 (failure) -- real
https://github.com/squid-protocol/gitgalaxy/actions/runs/42277463273/job/128097630615
repro: python -m pytest -q tests/cobol_mainframe/test_cobolrt_api.py::test_the_manifest_is_the_sources_surface
failing tests: tests/cobol_mainframe/test_cobolrt_api.py::test_the_manifest_is_the_sources_surface
errors:
fail-on-cache-miss: false
tests/cobol_mainframe/test_cobolrt_api.py:109: AssertionError
FAILED tests/cobol_mainframe/test_cobolrt_api.py::test_the_manifest_is_the_sources_surface - assert ["the manifes....py generate"] == []
##[error]Process completed with exit code 1.
log tail:
env:
GITGALAXY_LICENSE_KEY: COMMUNITY_FREE_TIER
GITGALAXY_MAINFRAME_CORPORA: /home/runner/work/gitgalaxy/gitgalaxy/.mainframe_corpora
MAINFRAME_ENGINE_KEY: a935b70bdc7c1ae70809869353f08342d13d8d6014cc9e7c42f9d180ef5a33bc
PYTHONUTF8: 1
pythonLocation: /opt/hostedtoolcache/Python/3.12.16/x64
PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.12.16/x64/lib/pkgconfig
Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.16/x64
Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.16/x64
Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.16/x64
LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.12.16/x64/lib
##[endgroup]
With the provided path, there will be 1 file uploaded
Artifact name is valid!
Root directory input is valid!
Uploading artifact: test-times-ground-truth-part-3.zip
Beginning upload of artifact content to blob storage
Uploaded bytes 92937
Finished uploading artifact content to blob storage!
SHA256 digest of uploaded artifact is 8a668e38248a2ddbbd399e9a667b3791b8363ff04d7be6c541b5762fd5f05755
Finalizing artifact upload
Artifact test-times-ground-truth-part-3 successfully finalized. Artifact ID 13534385758
Artifact test-times-ground-truth-part-3 has been successfully uploaded! Final size is 92937 bytes. Artifact ID is 13534385758
Artifact download URL: https://github.com/squid-protocol/gitgalaxy/actions/runs/42277463273/artifacts/13534385758
Post job cleanup.
[command]/usr/bin/git version
git version 2.56.0
Temporarily overriding HOME='/home/runner/work/_temp/aea4b9c0-f46d-426c-8b1b-711e9b5aac6e' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/usr/bin/git config --global --add safe.directory /home/runner/work/gitgalaxy/gitgalaxy/gitgalaxy
Removing SSH command configuration
[command]/usr/bin/git config --local --name-only --get-regexp core.sshCommand
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Removing HTTP extra header
[command]/usr/bin/git config --local --name-only --get-regexp http.https://github.com/.extraheader
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http.https://github.com/.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Removing includeIf entries pointing to credentials config files
[command]/usr/bin/git config --local --name-only --get-regexp ^includeIf.gitdir:
[command]/usr/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
Cleaning up orphan processes

@squid-shepherd squid-shepherd Bot added the shepherd:needs-fix Bot: a real failure on this head; see the digest comment. Guide: docs/ci.md label Nov 6, 2026
@squid-shepherd

squid-shepherd Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@squid-shepherd
squid-shepherd Bot enabled auto-merge (squash) November 6, 2026 20:08
@squid-shepherd squid-shepherd Bot removed shepherd:needs-fix Bot: a real failure on this head; see the digest comment. Guide: docs/ci.md shepherd:waiting-on-main Bot: the failing check fails on main too (main's to fix). Guide: docs/ci.md labels Nov 6, 2026
@squid-protocol squid-protocol added shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md and removed shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md labels Nov 6, 2026
@squid-shepherd

squid-shepherd Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@squid-shepherd
squid-shepherd Bot merged commit b91787d into main Nov 6, 2026
41 checks passed
@squid-shepherd
squid-shepherd Bot deleted the churn/7937-20261106T1851Z branch November 6, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

main is red: Full Suite Gate (All OS x Python)

1 participant