Skip to content

det: WEB CONVERSE takes the bare method keywords (Part of #7525, #7709) - #7942

Merged
squid-shepherd[bot] merged 2 commits into
mainfrom
churn/7525-20261106T1939Z
Nov 6, 2026
Merged

squid-shepherd[bot] merged 2 commits into
mainfrom
churn/7525-20261106T1939Z

Conversation

@squid-protocol

Copy link
Copy Markdown
Owner

Summary

WEB CONVERSE now takes IBM's bare method keywords (DELETE, GET, HEAD, OPTIONS, POST, PUT, TRACE) as the bare form of METHOD(cvda). The keyword resolves at translation time to the CVDA number in both the det port and the GnuCOBOL oracle emitter, so the runtime and the C stub are unchanged. The spec one_of group refuses none or two methods in both translators. TRACE / OPTIONS stay refused at run time by name.

Part of #7525, #7709.

Facts checked

  • det_port.py check: 270/270 ports unchanged.
  • audit_check.py: all clear; ruff format --check clean.
  • Targeted pytest set: 687 passed, 3 skipped. The Docker e2e is gated on EQUIVALENCE_E2E=1 and was not run here.
  • No change under language_standards, so no golden bless.

Sibling gaps

  • WEB OPEN SCHEME (HTTP / HTTPS bare), WEB CONVERSE CLIENTCONV (CLICONVERT / NOCLICONVERT), and WEB ACTION / DOCSTATUS are the same shape and not done (5-file limit). I could not locate a burned-estate program that needs them.

Not done

Cross-repo

No companion PR; no crucible change needed.

Lessons for agents

  • test_options_honoured_without_code_say_why needs each spec option as a quoted literal in the translator module; an imported tuple does not count.

🤖 Generated with Claude Code

…ONS/POST/PUT/TRACE (Part of #7525, #7709)

The bare keyword is IBM's form of METHOD(cvda). It resolves at translation
time to the CVDA number in both the det port and the GnuCOBOL oracle emitter,
so the runtime and the C stub are unchanged; the spec's one_of group refuses
none or two. TRACE / OPTIONS stay refused at run time by name.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@squid-protocol squid-protocol added the shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md label Nov 6, 2026
@squid-shepherd

squid-shepherd Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@squid-shepherd
squid-shepherd Bot marked this pull request as ready for review November 6, 2026 20:00
@squid-shepherd
squid-shepherd Bot enabled auto-merge (squash) November 6, 2026 20:01
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

🐦‍⬛ Muninn Security Scan

✅ No security issues found.

🐦‍⬛ Powered by Muninn · Skald Lab

@squid-shepherd
squid-shepherd Bot disabled auto-merge November 6, 2026 20:12
@squid-shepherd

squid-shepherd Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

PR #7942 @ e6c3a5e: 1 failed check(s)

== full-suite part 3/3 (failure) -- real
https://github.com/squid-protocol/gitgalaxy/actions/runs/42284643480/job/128123176470
repro: python -m pytest -q tests/core_engine/test_cics_spec.py::test_only_the_listed_consumers_import_the_spec
failing tests: tests/core_engine/test_cics_spec.py::test_only_the_listed_consumers_import_the_spec
errors:
fail-on-cache-miss: false
E AssertionError: assert {'gitgalaxy/t...inal.py', ...} == {'gitgalaxy/t...inal.py', ...}
tests/core_engine/test_cics_spec.py:115: AssertionError
FAILED tests/core_engine/test_cics_spec.py::test_only_the_listed_consumers_import_the_spec - AssertionError: assert {'gitgalaxy/t...inal.py', ...} == {'gitgalaxy/t...inal.py', ...}
##[error]Process completed with exit code 1.
log tail:
GITGALAXY_LICENSE_KEY: COMMUNITY_FREE_TIER
OMP_NUM_THREADS: 1
pythonLocation: /opt/hostedtoolcache/Python/3.12.16/x64
PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.12.16/x64/lib/pkgconfig
Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.16/x64
Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.16/x64
Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.16/x64
LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.12.16/x64/lib
PYTEST_ADDOPTS: --ignore=tests/cobol_mainframe
##[endgroup]
Multiple search paths detected. Calculating the least common ancestor of all paths
The least common ancestor is /home/runner/work/_temp. This will be the root directory of the artifact
With the provided path, there will be 2 files uploaded
Artifact name is valid!
Root directory input is valid!
Uploading artifact: test-times-part-3.zip
Beginning upload of artifact content to blob storage
Uploaded bytes 976092
Finished uploading artifact content to blob storage!
SHA256 digest of uploaded artifact is d9898187b79e1c2ec7edecd7cf38558d710d8497016cf3d8e720d3cbf3b66da7
Finalizing artifact upload
Artifact test-times-part-3 successfully finalized. Artifact ID 13537267553
Artifact test-times-part-3 has been successfully uploaded! Final size is 976092 bytes. Artifact ID is 13537267553
Artifact download URL: https://github.com/squid-protocol/gitgalaxy/actions/runs/42284643480/artifacts/13537267553
Post job cleanup.
[command]/usr/bin/git version
git version 2.56.0
Temporarily overriding HOME='/home/runner/work/_temp/4a335c7d-7c1f-4062-987c-2d6323d91c86' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/usr/bin/git config --global --add safe.directory /home/runner/work/gitgalaxy/gitgalaxy
Removing SSH command configuration
[command]/usr/bin/git config --local --name-only --get-regexp core.sshCommand
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Removing HTTP extra header
[command]/usr/bin/git config --local --name-only --get-regexp http.https://github.com/.extraheader
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http.https://github.com/.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Removing includeIf entries pointing to credentials config files
[command]/usr/bin/git config --local --name-only --get-regexp ^includeIf.gitdir:
[command]/usr/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
Cleaning up orphan processes

@squid-shepherd squid-shepherd Bot added the shepherd:needs-fix Bot: a real failure on this head; see the digest comment. Guide: docs/ci.md label Nov 6, 2026
… spec package (Part of #7525)

test_only_the_listed_consumers_import_the_spec pins the spec's importers;
equivalence_cics_web.py now reads METHOD_WORDS from det/cics_web.py instead.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@squid-shepherd squid-shepherd Bot removed the shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md label Nov 6, 2026
@squid-shepherd

squid-shepherd Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

CI shepherd: the head of this PR (a761b52) is not the one a maintainer labelled shepherd:merge on (new commits, or never approved), so the label was removed and nothing merges unreviewed code. Re-add the label when the new head is ready (shepherd:reapprove marks this PR until then). Until then it is a draft and runs the cheap audits only; re-adding the label marks it ready, which starts the full set on that head.

@squid-shepherd
squid-shepherd Bot marked this pull request as draft November 6, 2026 20:13
@squid-shepherd squid-shepherd Bot added shepherd:reapprove Bot: new commits dropped shepherd:merge; re-add it to merge this head. Guide: docs/ci.md and removed shepherd:needs-fix Bot: a real failure on this head; see the digest comment. Guide: docs/ci.md labels Nov 6, 2026
@squid-protocol squid-protocol added shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md and removed shepherd:reapprove Bot: new commits dropped shepherd:merge; re-add it to merge this head. Guide: docs/ci.md labels Nov 6, 2026
@squid-shepherd

squid-shepherd Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@squid-shepherd
squid-shepherd Bot marked this pull request as ready for review November 6, 2026 20:14
@squid-shepherd squid-shepherd Bot added the shepherd:retrying Bot: an infra/flake rerun is pending on this head. Guide: docs/ci.md label Nov 6, 2026
@squid-shepherd
squid-shepherd Bot enabled auto-merge (squash) November 6, 2026 20:15
@squid-shepherd

squid-shepherd Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@squid-shepherd squid-shepherd Bot removed the shepherd:retrying Bot: an infra/flake rerun is pending on this head. Guide: docs/ci.md label Nov 6, 2026
@squid-shepherd
squid-shepherd Bot merged commit f27e38f into main Nov 6, 2026
108 of 131 checks passed
@squid-shepherd
squid-shepherd Bot deleted the churn/7525-20261106T1939Z branch November 6, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant