ability to hide the server icon #1387
Merged
+88
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andymandias
requested changes
Jan 5, 2026
Collaborator
andymandias
left a comment
andymandias
left a comment
There was a problem hiding this comment.
Looks good! One change I think we should make: fall back to the default icon state when the server icon is hidden rather than hide all icons. That is, show the unread indicator icon if Halloy is configured to do so.
src/screen/dashboard/sidebar.rs
Outdated
| .size(size), | ||
| size, | ||
| )), | ||
| data::config::sidebar::ServerIcon::Hidden => None, |
Collaborator
There was a problem hiding this comment.
I think we should show the unread/highlight icon (as appropriate) in this case, as if it were any other upstream buffer. Otherwise, unread status will not be indicated.
Member
Author
There was a problem hiding this comment.
thats a great feedback, take a look at newest commit and let me know.
andymandias
approved these changes
Jan 5, 2026
Collaborator
andymandias
left a comment
andymandias
left a comment
There was a problem hiding this comment.
A really nice option, cleanly executed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to hide server icon with:
or adjust the size like before:
Another small change is that if we are not connected to a server we also color the title:
This serves two purposes: