Skip to content

feat(ui): improve list and question rendering - #228

Merged
srothgan merged 5 commits into
mainfrom
refactor/ui-lists-questions-tests
Jul 1, 2026
Merged

feat(ui): improve list and question rendering#228
srothgan merged 5 commits into
mainfrom
refactor/ui-lists-questions-tests

Conversation

@srothgan

@srothgan srothgan commented Jul 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • Remove stale test-only helpers that existed only to exercise old production code.
  • Render markdown lists with indentation instead of injected blank lines.
  • Add structured AskUserQuestion result payloads and render answered questions with selected answers, descriptions, previews, and notes.
  • Improve interactive AskUserQuestion layout, titles, option spacing, and multi-select Space handling.
  • Add a CodeQL code scanning workflow.

Why

This keeps the UI more compact and predictable while preserving the useful structure from user question interactions. It also removes test scaffolding that hid dead-code cleanup signals and adds security scanning coverage for the repository.

Closes # N/A

Validation

  • Automated:
    • cargo fmt --all -- --check
    • cargo check
    • cargo clippy --all-targets --all-features -- -D warnings
    • cargo test --quiet
    • npm.cmd run build
    • npm.cmd run lint
    • npm.cmd test
  • Manual:
    • Exercised list rendering with nested, ordered, unordered, mixed, and loose-list examples.
    • Exercised AskUserQuestion rendering for single-select, multi-select, multi-step questions, previews, notes, and completed answers.
  • Screenshot/video (if UI changed): Local screenshots captured during validation.

Notes

  • Breaking changes: N/A
  • Docs updated: N/A

srothgan added 4 commits July 1, 2026 21:07
@srothgan
refactor(tests): remove stale test-only helpers
276dc05 
- Remove dead count_text_lines helper and self-referential test
- Drop terminal session-kind helper that only existed for tests
- Exercise model overlay title rendering through production span output
@srothgan
fix(ui): render lists with indentation instead of blank gaps
a1e6c87 
- indent ordered and unordered markdown list rows during rendering
- remove renderer-added blank rows directly around list items
- suppress streamed paragraph gaps when a text-block boundary touches a list
- preserve normal paragraph spacing for non-list text blocks
- add markdown and live assistant row regression coverage
@srothgan
feat(ui): structure ask user question rendering
54683ec 
- Preserve answered AskUserQuestion details as structured bridge payloads
- Render completed answers with selected options, previews, and notes
- Improve interactive question layout, spacing, and stable titles
- Keep Space focused on multi-select questions for option toggling
@srothgan
ci(codeql): add code scanning workflow
2639ad7 
- Run CodeQL analysis for the repository
- Configure GitHub security scanning via workflow
- Keep code scanning setup separate from UI rendering changes
@srothgan srothgan self-assigned this Jul 1, 2026
@srothgan srothgan added type: feature New feature or capability type: refactor Refactoring, performance, tests, and code style labels Jul 1, 2026
@github-advanced-security

github-advanced-security AI commented Jul 1, 2026

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@srothgan
docs(changelog): add PR 228 unreleased notes
dc4f036 
- Document list and AskUserQuestion rendering changes
- Note stale test helper cleanup
- Include CodeQL workflow addition under CI
@srothgan
srothgan merged commit ca9c30e into main Jul 1, 2026
17 checks passed
@srothgan
srothgan deleted the refactor/ui-lists-questions-tests branch July 1, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@srothgan srothgan

Labels

type: feature New feature or capability type: refactor Refactoring, performance, tests, and code style

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@srothgan @github-advanced-security