Repository navigation
Let .env set the home quota and the free-space floor - #19
Merged
Merged
Conversation
docker-compose.yml passes only the settings it names to goftp, so GOFTP_HOMES_QUOTA and GOFTP_UPLOAD_MIN_FREE in .env did nothing. Both are passed now, with goftp's defaults (no quota, 1GiB), and .env.example describes them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker-compose.ymlpasses goftp only the variables it names, soGOFTP_HOMES_QUOTA(from #18) andGOFTP_UPLOAD_MIN_FREE(from #17) set in.envnever reached the server.docker-compose.ymlnow passes both, defaulting to goftp's own defaults: no quota, and 1 GiB of free disk..env.exampledescribes both.GOFTP_UPLOAD_MIN_FREEnext toupload.min_free.Checked with
docker compose config: unset, they render as0and1GiB; set in the environment, they come through as given.After merging: CI doesn't update yuhaha's copy of
docker-compose.yml, which is root's. It has to be installed there again by hand, as the README's Deploying section says.🤖 Generated with Claude Code