Repository navigation
Conversation
Users can add passkeys under Passkeys in their account menu, after their password, and then sign in with one from the sign-in page's button, or by picking it where the browser offers it under the username. Passkeys are discoverable WebAuthn credentials that need user verification, bound to the site's host name; signing in with one asks no two-factor code, as it is a second factor in itself. A new temporary password deletes the user's passkeys, as after a break-in. Starting passkey sign-ins is limited per client, and refused passkeys count against the client's sign-in budget. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #26 (gallery), which is stacked on #25 (folder share end dates). Merge #25, then #26, then this one.
What it does
/.auth/passkeys): add one per device, up to 10, after confirming your password. Each one shows when it was added and last used, and can be deleted.autocomplete="username webauthn", conditional mediation).goftp user passwd) deletes the user's passkeys, as after a break-in. Changing your own password keeps them.How it works
github.com/go-webauthn/webauthnv0.18.2. Credentials are discoverable, user verification is required, and no attestation is requested.c.BaseURL(), so passkeys are bound to the host the site is reached at;http://localhost(not on bare IP addresses).passkeystable holding the credential record as JSON: public key, sign counter and flags. A signature counter that goes backwards means a cloned key, and is refused.Store.UserByIDis added for the lookup.PublicKeyCredential.parse*OptionsFromJSONandtoJSON()where the browser has them, with base64url fallbacks for older ones.readSmallBody, shared with the new JSON endpoints.Tests
The software authenticator
github.com/descope/virtualwebauthn(test-only) drives these:nextthat can't point to another site;TestSymlinkslooked for the bare wordpubanywhere in the page, which the new inline script contains (publicKey); it now looks at listing entries.-raceand Postgres on macOS, except the known macOS-onlyTestLongNonASCIIPath.TestFolderSharingonce hit the test client's 5-second timeout under full-suite race load; it passes 3 of 3 on its own. CI runs Linux.http://localhost:parseCreationOptionsFromJSONandparseRequestOptionsFromJSONaccept the server's options (site ID, user, 32-byte challenge, resident key and user verification required);After deploy
Check that adding a passkey on ftp.ssenerg.com works. It depends on the proxy passing the real
Host(andX-Forwarded-Proto) through, which share links already rely on.🤖 Generated with Claude Code