Skip to content

Preserve non-stereo DTD flags and stop draft insertion on Export - #5

Merged
ssupt merged 2 commits into
mainfrom
fix/non-stereo-export
Oct 9, 2026
Merged

ssupt merged 2 commits into
mainfrom
fix/non-stereo-export

Conversation

@ssupt

@ssupt ssupt commented Oct 9, 2026

Copy link
Copy Markdown
Owner

In 0.1.4, stereo cleanup changes non-stereo DTD flag bytes such as 0x19 → 0x18 and 0x1b → 0x1a, repairs their checksums, and reports false pending overrides. Only bits 6:5 indicate a stereo format; bit 0 alone must be preserved.

The first commit corrects that detection and covers base/CTA descriptors, mixed stereo and non-stereo timings, pending override detection, and a VRR export that changes only the requested range and checksum.

The second commit fixes a separate export problem: when no EDID edits were pending, Export inserted the current draft timing, initially 2560×1440@144. Export now requires pending workspace changes, matching Install/Update, and writes the working EDID. Genuine stereo cleanup remains eligible. Explicit Add operations can still append a CTA extension when existing slots are full. Missing-monitor/EDID messages and validation of all EDID blocks and timing fields are covered.

Validation:

  • All 143 tests pass in debug, release, and Rust 1.87.0.
  • Formatting, Clippy with warnings denied, whitespace checks, and the release build pass.
  • An 80×24 demo smoke test confirms unchanged Export displays the no-pending-changes message and quits cleanly.
  • New regression tests reproduced the stereo misclassification and unchanged-export fallback before their fixes.

Reported by neheb on issue #3. The corrections follow their proposed fix, with broader regression coverage and retained missing-EDID diagnostics.

ssupt added 2 commits October 9, 2026 05:21
Only classify a detailed timing as stereo when bits 6:5 are nonzero.
Keep bit 0 and the checksum unchanged for non-stereo timings, including
the reported 0x19 and 0x1b flags.

Cover base and CTA timings, mixed stereo/non-stereo descriptors, pending
override detection, and a VRR export that preserves all unrelated bytes.

Reported by neheb in issue #3; the detection correction follows their
proposed fix at bbcc068.
Require pending workspace changes before Export opens confirmation or
writes files, matching Install/Update. Remove the fallback that inserted
the current draft timing when no EDID edits were pending.

Keep real stereo cleanup eligible for export and validate the working
EDID rather than the unused draft. Preserve explicit Add operations that
append a CTA extension, and retain validation of all checksums and timing
fields. Document the export behavior and cover unchanged, stereo-only,
invalid, and missing-EDID cases.

This follows the export behavior change proposed by neheb in the issue #3
follow-up, with additional regression coverage and missing-EDID messages.
@ssupt
ssupt marked this pull request as ready for review October 9, 2026 03:33
@ssupt
ssupt merged commit d3f67f1 into main Oct 9, 2026
6 checks passed
ssupt added a commit that referenced this pull request Oct 9, 2026
The changes proposed by neheb were incorporated in PR #5, with additional regression tests and validation. Record the original authored commit in main so GitHub can credit the contributor. Keep the already tested implementation and 0.1.5 release metadata unchanged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant