Repository navigation
Preserve non-stereo DTD flags and stop draft insertion on Export - #5
Merged
Merged
Conversation
Only classify a detailed timing as stereo when bits 6:5 are nonzero. Keep bit 0 and the checksum unchanged for non-stereo timings, including the reported 0x19 and 0x1b flags. Cover base and CTA timings, mixed stereo/non-stereo descriptors, pending override detection, and a VRR export that preserves all unrelated bytes. Reported by neheb in issue #3; the detection correction follows their proposed fix at bbcc068.
Require pending workspace changes before Export opens confirmation or writes files, matching Install/Update. Remove the fallback that inserted the current draft timing when no EDID edits were pending. Keep real stereo cleanup eligible for export and validate the working EDID rather than the unused draft. Preserve explicit Add operations that append a CTA extension, and retain validation of all checksums and timing fields. Document the export behavior and cover unchanged, stereo-only, invalid, and missing-EDID cases. This follows the export behavior change proposed by neheb in the issue #3 follow-up, with additional regression coverage and missing-EDID messages.
ssupt
marked this pull request as ready for review
October 9, 2026 03:33
ssupt
added a commit
that referenced
this pull request
Oct 9, 2026
The changes proposed by neheb were incorporated in PR #5, with additional regression tests and validation. Record the original authored commit in main so GitHub can credit the contributor. Keep the already tested implementation and 0.1.5 release metadata unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 0.1.4, stereo cleanup changes non-stereo DTD flag bytes such as
0x19 → 0x18and0x1b → 0x1a, repairs their checksums, and reports false pending overrides. Only bits 6:5 indicate a stereo format; bit 0 alone must be preserved.The first commit corrects that detection and covers base/CTA descriptors, mixed stereo and non-stereo timings, pending override detection, and a VRR export that changes only the requested range and checksum.
The second commit fixes a separate export problem: when no EDID edits were pending, Export inserted the current draft timing, initially 2560×1440@144. Export now requires pending workspace changes, matching Install/Update, and writes the working EDID. Genuine stereo cleanup remains eligible. Explicit Add operations can still append a CTA extension when existing slots are full. Missing-monitor/EDID messages and validation of all EDID blocks and timing fields are covered.
Validation:
Reported by neheb on issue #3. The corrections follow their proposed fix, with broader regression coverage and retained missing-EDID diagnostics.