Repository navigation
Keep stream-player association working on Omarchy 4.0.3 scoped hosts - #16
Merged
Merged
Conversation
4.0.3 capability-scopes plugin shell access and answers null for firstPartyServiceFor(omarchy.media), so activeMediaPlayer stayed null and no stream was marked as representing the player. Keep the service object first for older hosts and add a local fallback mirroring the first-party selection for the reachable case, built from the existing MPRIS/stream matching helpers in Model.js. Version 0.8.1.
ssupt
added a commit
that referenced
this pull request
Sep 12, 2026
Port the fallback from PR #16 with paused-stream priority and regression coverage. Co-authored-by: MACHO MAN <machoxv@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Omarchy hosts that restrict
firstPartyServiceFor("omarchy.media")return no media service to this plugin, leaving playback streams without their player association.Use the host's active player when available; otherwise select from the existing MPRIS players and playback streams. Prefer playing players with a matching stream, then other playing players, paused players with a stream, and controllable players. Each tier prefers real players over proxies.
The fallback uses list order. It cannot read the host's pinned source or playback-start history, so its choice can differ from the media widget. A selected paused player's stream remains associated; the indicator does not imply audible playback.
The tests now read the diagnostics version from the manifest and check its format, so the 0.8.1 bump passes. Added regressions cover paused stream association, playing priority, proxy preference, list order, empty input and QML-like sequences. The paused-player regression fails on the original PR and passes with the fix; the full suite passes.
This compatibility fix also applies to the Rust migration in #15.