Skip to content

Keep stream-player association working on Omarchy 4.0.3 scoped hosts - #16

Merged
ssupt merged 2 commits into
ssupt:mainfrom
Macho0x:fix/omarchy-4.0.3-media-fallback
Sep 12, 2026
Merged

ssupt merged 2 commits into
ssupt:mainfrom
Macho0x:fix/omarchy-4.0.3-media-fallback

Conversation

@Macho0x

@Macho0x Macho0x commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Omarchy hosts that restrict firstPartyServiceFor("omarchy.media") return no media service to this plugin, leaving playback streams without their player association.

Use the host's active player when available; otherwise select from the existing MPRIS players and playback streams. Prefer playing players with a matching stream, then other playing players, paused players with a stream, and controllable players. Each tier prefers real players over proxies.

The fallback uses list order. It cannot read the host's pinned source or playback-start history, so its choice can differ from the media widget. A selected paused player's stream remains associated; the indicator does not imply audible playback.

The tests now read the diagnostics version from the manifest and check its format, so the 0.8.1 bump passes. Added regressions cover paused stream association, playing priority, proxy preference, list order, empty input and QML-like sequences. The paused-player regression fails on the original PR and passes with the fix; the full suite passes.

This compatibility fix also applies to the Rust migration in #15.

Macho0x and others added 2 commits September 10, 2026 19:31
4.0.3 capability-scopes plugin shell access and answers null for
firstPartyServiceFor(omarchy.media), so activeMediaPlayer stayed null
and no stream was marked as representing the player. Keep the service
object first for older hosts and add a local fallback mirroring the
first-party selection for the reachable case, built from the existing
MPRIS/stream matching helpers in Model.js. Version 0.8.1.
ssupt added a commit that referenced this pull request Sep 12, 2026
Port the fallback from PR #16 with paused-stream priority and regression coverage.

Co-authored-by: MACHO MAN <machoxv@protonmail.com>
@ssupt
ssupt merged commit 71c0b6a into ssupt:main Sep 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants