Skip to content

Keep audio device selection responsive - #26

Merged
ssupt merged 3 commits into
ssupt:mainfrom
duketopceo:luke
Oct 20, 2026
Merged

ssupt merged 3 commits into
ssupt:mainfrom
duketopceo:luke

Conversation

@duketopceo

@duketopceo duketopceo commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Allow selecting a valid output or microphone after the previous default leaves the audio graph.
  • Keep device rows, saved scenes, and advanced audio navigation responsive, with feedback when an action cannot proceed.
  • Allow routing requests to queue behind volume changes while retaining transaction and stale-device guards.
  • Clear temporary interaction feedback on retry without discarding failed or unsaved backend results.

Includes the changes from #25. The bundled runtime and backend match the updated sources.

Validation

  • Complete local suite, offscreen QML rendering, private PipeWire runtime and profile restoration, and packaged native startup passed.
  • All CI checks passed, including Rust 1.85 and stable, full Quickshell UI and upgrade coverage, and x86_64/aarch64 package builds.

duketopceo and others added 3 commits October 19, 2026 19:28
setDefaultDevice() silently returned false whenever the *current*
default could not be resolved to a backend identity — a routine state
after device churn (dock replug, USB audio flap, BT reconnect,
suspend/resume) — leaving every row visually enabled but dead until
something else changed the default. The backend recomputes the
previous default from routing state on its own, so pass
previous:null instead of aborting.

Also:
- Surface every early-return as the direction's error text so a dead
  click reports *why* instead of no-opping.
- Narrow row disabling to an actual in-flight default.set or scene
  apply; the backend 'busy' flag flaps during unrelated PipeWire
  churn and left rows unclickable for long stretches.
Adopts the direct-call/visible-error idiom used by our fan plugin instead
of upstream's busy-gate pattern, which left rows dead for stretches:

- Device rows are always clickable. A click that can't complete now
  reports why in the panel's error line instead of silently no-opping
  behind a disabled MouseArea.
- Mute toggles, keyboard volume adjust, stream routing, and scene apply
  all surface their busy/stale failure reason; scene rejections use the
  existing inline sceneFeedback surface.
- Opening the advanced view is no longer blocked during scene applies.

Backend contract is unchanged; this only removes frontend gates that
were stricter than the service requires.
@ssupt ssupt changed the title Restyle panel interactions: clicks always land, failures always show Keep audio device selection responsive Oct 20, 2026
@ssupt
ssupt merged commit a67a010 into ssupt:main Oct 20, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants